Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] fftwf: Add fftwf package for single precision fft
Date: Thu, 11 Apr 2013 19:33:30 +0200	[thread overview]
Message-ID: <20130411193330.37ecd3ac@skate> (raw)
In-Reply-To: <1365691684-30663-1-git-send-email-spenser@gillilanding.com>

Dear Spenser Gilliland,

On Thu, 11 Apr 2013 09:48:03 -0500, Spenser Gilliland wrote:

> +FFTWF_VERSION = 3.3.2
> +FFTWF_SITE = http://www.fftw.org
> +FFTWF_SOURCE = fftw-$(FFTWF_VERSION).tar.gz
> +FFTWF_INSTALL_STAGING = YES

package/fftw/ that already exists in Buildroot builds the exact same
source code. Why do you think a different package is needed?

Why don't you just add the:

+ifeq ($(BR2_ARM_ENABLE_NEON),y)
+FFTWF_CONF_OPT = --enable-single --enable-neon
+FFTWF_CONF_ENV += \
+	CFLAGS="$(TARGET_CFLAGS) -mfpu=neon -mfloat-abi=softfp"
+else
+FFTWF_CONF_OPT = --enable-single
+endif

block of code into package/fftw/fftw.mk ?

In Buildroot, we generally have one package for each source tarball.
But this package may provide different configuration options to adapt
to the specificities of the platform, or to provide different kind of
features.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  parent reply	other threads:[~2013-04-11 17:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-11 14:48 [Buildroot] [PATCH] fftwf: Add fftwf package for single precision fft Spenser Gilliland
2013-04-11 14:48 ` [Buildroot] [PATCH] fs: add uimage support w/ example for cpio Spenser Gilliland
2013-04-11 16:41   ` Sören Brinkmann
2013-04-11 17:39   ` Thomas Petazzoni
2013-04-11 17:33 ` Thomas Petazzoni [this message]
2013-04-11 18:17   ` [Buildroot] [PATCH] fftwf: Add fftwf package for single precision fft Spenser Gilliland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130411193330.37ecd3ac@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox