From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libserial: new package
Date: Tue, 16 Apr 2013 09:35:40 +0200 [thread overview]
Message-ID: <20130416093540.5cbdade3@skate> (raw)
In-Reply-To: <1366096804-2032-1-git-send-email-spdawson@gmail.com>
Simon,
On Tue, 16 Apr 2013 08:20:04 +0100, spdawson at gmail.com wrote:
> +LIBSERIAL_VERSION = 0.5.2
> +LIBSERIAL_SITE = http://prdownloads.sourceforge.net/libserial
I think prdownloads.sourceforge.net is just one particular mirror of
Sourceforge, and we now prefer to use http://downloads.sourceforge.net,
which automatically redirects to one available mirror. See all existing
BR packages whose upstream tarball is hosted on Github.
Besides that, your patch is numbered 0000, while the other packages
that we have typically have the patches numbered from 1. This is also
what git format-patch does by default (numbering from 1). We don't have
a strict policy with written rules about this, but the common practice
apparently is to start the patches from 1.
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-04-16 7:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 7:20 [Buildroot] [PATCH] libserial: new package spdawson at gmail.com
2013-04-16 7:35 ` Thomas Petazzoni [this message]
2013-04-16 7:39 ` Simon Dawson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130416093540.5cbdade3@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox