From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] support/kconfig: use kconfig-provided way of setting the CONFIG_ prefix
Date: Wed, 17 Apr 2013 09:45:53 +0200 [thread overview]
Message-ID: <20130417094553.3a47343b@skate> (raw)
In-Reply-To: <20130416213424.GA14974@free.fr>
Dear Yann E. MORIN,
On Tue, 16 Apr 2013 23:34:24 +0200, Yann E. MORIN wrote:
> That's the whole point of this patch: use Kconfig ability to understand
> any prefix other than the default 'CONFIG_', and even an empty prefix:
>
> -HOST_EXTRACFLAGS += -I$(obj)
> +HOST_EXTRACFLAGS += -I$(obj) -DCONFIG_=\"\"
> ^^^^^^^^^^^^^^
>
> This tells that the option prefix is empty, so:
> Config.in .config
> --------------------------------------------
> config FOO FOO=y
> config BR2_BAR # BR2_BAR is not set
>
>
> If I did use: -DCONFIG_=\"YEM\" , then that would give:
> Config.in .config
> --------------------------------------------
> config FOO YEM_FOO=y
> config BR2_BAR # YEM_BR2_BAR is not set
>
>
> So yes, this patch maintains our do-not-add-a-prefix-to-options policy. ;-)
Aah, ok. That explains why I wasn't seeing our 'BR2_' prefix anywhere
in your change. It's because we tell kconfig "We don't have a prefix",
and in fact our prefix is hardcoded directly into each and every
Config.in option. Makes sense.
So I haven't tested your patch, but on the principle, it definitely
looks great.
> PS. It is even possible to override that prefix at runtime, too, but
> that's not the path I choose in this patch.
I think the compile time choice you made is fine.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-04-17 7:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-14 12:53 [Buildroot] [PATCH] support/kconfig: use kconfig-provided way of setting the CONFIG_ prefix Yann E. MORIN
2013-04-16 21:06 ` Thomas Petazzoni
2013-04-16 21:34 ` Yann E. MORIN
2013-04-17 7:45 ` Thomas Petazzoni [this message]
2013-04-21 21:35 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130417094553.3a47343b@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox