From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Wed, 17 Apr 2013 10:56:15 +0200 Subject: [Buildroot] [PATCH v5 6/7] arch: toolchain: Install blackfin FDPIC and FLAT libraries in external toolchain makefile. In-Reply-To: References: <1365761909-15305-1-git-send-email-sonic.adi@gmail.com> <1365761909-15305-6-git-send-email-sonic.adi@gmail.com> <20130416232925.759eb9df@skate> <20130417100512.5433f4c6@skate> Message-ID: <20130417105615.7af600cd@skate> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear Sonic Zhang, On Wed, 17 Apr 2013 16:16:21 +0800, Sonic Zhang wrote: > > # When the FDPIC binary format is used, we force the installation > > # of the corresponding libraries. When a different binary format is > > # used, we offer the option of installing the FDPIC shared libraries > > # (typically in addition to the FLAT shared ones). > > config BR2_BFIN_INSTALL_FDPIC_SHARED > > bool "Install FDPIC shared libraries" if !BR2_BINFMT_FDPIC > > default y if BR2_BINFMT_FDPIC > > help > > ... > > Because current library installation scripts in > toolchain-external/ext-tool.mk always install FDPIC libraries when > BINFMT_FDPIC is selected. No necessary to set > BR2_BFIN_INSTALL_FDPIC_SHARED y in this case. Ok. But then why do we have to duplicate this code in ext-tool.mk. If it already has the code to copy the FDPIC libraries when FDPIC is selected as the primary binary format, we should be able to re-use this code when FLAT shared is used as the primary binary format, but we want the FDPIC libraries to be installed in addition. Thanks, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com