Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 7/7] arc: Make sure that libgcc doesn't get included when it doesn't exist yet
Date: Mon, 22 Apr 2013 17:57:55 +0200	[thread overview]
Message-ID: <20130422175755.67229d29@skate> (raw)
In-Reply-To: <1366630651-6857-8-git-send-email-mjonker@synopsys.com>

Dear Mischa Jonker,

On Mon, 22 Apr 2013 13:37:31 +0200, Mischa Jonker wrote:
> For ARC, libgcc is always included, even when -nostdlib is given. This is
> related to some small pieces of code that are not always generated by the
> compiler; a call to libgcc is used in those cases instead.
> 
> During the initial stages of building the toolchain, this is a problem, as
> libgcc does not exist yet. The ARC compiler supports -really-nostdlib to
> override the default behavior.
> 
> Signed-off-by: Mischa Jonker <mjonker@synopsys.com>
> ---
>  toolchain/uClibc/uclibc.mk |   10 ++++++++--
>  1 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/toolchain/uClibc/uclibc.mk b/toolchain/uClibc/uclibc.mk
> index 1629e76..14083a9 100644
> --- a/toolchain/uClibc/uclibc.mk
> +++ b/toolchain/uClibc/uclibc.mk
> @@ -404,6 +404,12 @@ ifeq ($(BR2_CCACHE),y)
>  $(UCLIBC_DIR)/.config: | host-ccache
>  endif
>  
> +ifeq ($(BR2_arc)$(BR2_arceb),)
> +REALLY_NOSTDLIB=
> +else
> +REALLY_NOSTDLIB=-really-nostdlib
> +endif

Could you copy/paste parts of your commit log as a comment above this
piece of code? This would make it easier to understand. Also, you could
write it this way:

ifeq ($(BR2_arc)$(BR2_arceb),y)
REALLY_NOSTDLIB=-really-nostdlib
endif

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-04-22 15:57 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-22 11:37 [Buildroot] [PATCH 0/7] RFC: ARC port Mischa Jonker
2013-04-22 11:37 ` [Buildroot] [PATCH 1/7] arc: Add ARC and ARC BE architecture Mischa Jonker
2013-04-22 15:47   ` Thomas Petazzoni
2013-04-22 18:40   ` Arnout Vandecappelle
2013-04-22 11:37 ` [Buildroot] [PATCH 2/7] arc: Add option for ARC-specific download site Mischa Jonker
2013-04-22 15:48   ` Thomas Petazzoni
2013-04-22 18:25     ` Arnout Vandecappelle
2013-04-22 11:37 ` [Buildroot] [PATCH 3/7] arc: Add support for ARC-specific binutils Mischa Jonker
2013-04-22 15:49   ` Thomas Petazzoni
2013-04-22 18:35   ` Arnout Vandecappelle
2013-04-22 18:36   ` Arnout Vandecappelle
2013-04-22 11:37 ` [Buildroot] [PATCH 4/7] arc: Add ARC specific kernel headers Mischa Jonker
2013-04-22 15:52   ` Thomas Petazzoni
2013-04-22 11:37 ` [Buildroot] [PATCH 5/7] arc: Add support for ARC-specific GCC Mischa Jonker
2013-04-22 15:56   ` Thomas Petazzoni
2013-04-24 12:44     ` Mischa Jonker
2013-04-24 14:27       ` Thomas Petazzoni
2013-04-24 15:19         ` Mischa Jonker
2013-04-24 21:19           ` Yann E. MORIN
2013-04-22 11:37 ` [Buildroot] [PATCH 6/7] arc: Add support for ARC-specific uClibc Mischa Jonker
2013-04-22 15:56   ` Thomas Petazzoni
2013-04-22 11:37 ` [Buildroot] [PATCH 7/7] arc: Make sure that libgcc doesn't get included when it doesn't exist yet Mischa Jonker
2013-04-22 15:57   ` Thomas Petazzoni [this message]
2013-04-22 15:46 ` [Buildroot] [PATCH 0/7] RFC: ARC port Thomas Petazzoni
2013-04-22 16:01 ` [Buildroot] Plan of libffi support? Thomas Petazzoni
2013-04-24  6:38   ` Mischa Jonker
2013-04-24 14:38     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130422175755.67229d29@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox