From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] wvstreams: new package
Date: Thu, 25 Apr 2013 15:50:24 +0200 [thread overview]
Message-ID: <20130425155024.7142922d@skate> (raw)
In-Reply-To: <1366881542-15350-2-git-send-email-spdawson@gmail.com>
Simon,
This one looks good. Just a few questions below.
On Thu, 25 Apr 2013 10:19:01 +0100, spdawson at gmail.com wrote:
> diff --git a/package/wvstreams/wvstreams.mk b/package/wvstreams/wvstreams.mk
> new file mode 100644
> index 0000000..341fc09
> --- /dev/null
> +++ b/package/wvstreams/wvstreams.mk
> @@ -0,0 +1,51 @@
> +#############################################################
> +#
> +# wvstreams
> +#
> +#############################################################
> +
> +WVSTREAMS_VERSION = 4.6.1
> +WVSTREAMS_SITE = http://wvstreams.googlecode.com/files
> +WVSTREAMS_DEPENDENCIES = openssl zlib
openssl/zlib dependencies are mandatory here...
> +WVSTREAMS_INSTALL_STAGING = YES
> +
> +WVSTREAMS_LICENSE = LGPLv2+
> +WVSTREAMS_LICENSE_FILES = LICENSE
> +
> +# N.B. parallel make fails
> +WVSTREAMS_MAKE = $(MAKE1)
> +
> +# Needed to work around problem with wvassert.h
> +WVSTREAMS_CONF_OPT += CPPFLAGS=-DNDEBUG
> +
> +WVSTREAMS_CONF_OPT += --with-openssl --with-zlib --without-pam
but this seems to suggest that openssl/zlib support is not mandatory.
Can we make this optional if it's possible?
Other than that, it looks good to me.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-04-25 13:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-25 9:19 [Buildroot] [PATCH 0/2] Add wvstreams and wvdial packages spdawson at gmail.com
2013-04-25 9:19 ` [Buildroot] [PATCH 1/2] wvstreams: new package spdawson at gmail.com
2013-04-25 13:50 ` Thomas Petazzoni [this message]
2013-04-25 19:30 ` Simon Dawson
2013-05-06 11:31 ` Peter Korsgaard
2013-04-25 9:19 ` [Buildroot] [PATCH 2/2] wvdial: " spdawson at gmail.com
2013-04-25 13:57 ` Thomas Petazzoni
2013-04-25 19:38 ` Simon Dawson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130425155024.7142922d@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox