Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 00/12] RFC: ARC port
Date: Wed, 1 May 2013 00:09:05 +0200	[thread overview]
Message-ID: <20130501000905.609d0ced@skate> (raw)
In-Reply-To: <517FEC03.1010709@mind.be>

Dear Arnout Vandecappelle,

On Tue, 30 Apr 2013 18:06:27 +0200, Arnout Vandecappelle wrote:
> On 29/04/13 22:45, Thomas Petazzoni wrote:
> >   * I am not entirely happy with 'toolchain/gcc: Introduce
> >     BR2_ARCH_HAS_NO_GCC_x_y' using a reverted logic. I haven't thought
> >     too much about it, but wouldn't it be possible to instead do
> >     something like BR2_ARCH_NEEDS_GCC_4_6_PLUS, and then do something
> >     like depends !BR2_ARCH_NEEDS_GCC_4_6_PLUS on all gcc versions <
> >     4.6 ? Hum, the problem is that it works with architecture that are
> >     supported starting from a given upstream gcc version, but not
> >     architecture that are supported only in 4.2-avr, or in 4.4-arc, etc.
> >
> >     Maybe others will have a suggestion on this point?
> 
>   Not entirely clean either, but what about the following:
> 
> [toolchain/gcc/Config.in]
> config BR2_ARCH_HAS_ALL_GCC
> 	bool
> 
> config BR2_ARCH_HAS_GCC_4_4
> 	bool
> 	default y if BR2_ARCH_HAS_ALL_GCC
> 
> [arch/Config.in]
> config BR2_mips
> 	select BR2_ARCH_HAS_ALL_GCC
> ...
> 
> [arch/Config.in.arm]
> config BR2_arm1176jzf_s
> 	select BR2_ARCH_HAS_ALL_GCC
> ...
> config BR2_cortex_a8
> 	select BR2_ARCH_HAS_GCC_4_4
> ...

Could be good. That said, this problem is quite different from doing
the ARC port. So maybe we could instead tell Mischa to revert back to
its original solution (adding yet another set of !BR2_arc everywhere),
and we can work on a solution to improve this as a follow-up patch. Of
course, if Mischa is willing to work on this, that'd be great, but I
don't think it's really mandatory to make this cleanup a strict
requirement to get the ARC code merged. The existing set of 'depends
on' for gcc versions is already ugly, it's not specifically the ARC
stuff that makes it ugly.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-04-30 22:09 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-24 10:13 [Buildroot] [PATCH v2 00/12] RFC: ARC port Mischa Jonker
2013-04-24 10:13 ` [Buildroot] [PATCH v2 01/12] arc: Add ARC and ARC BE architecture Mischa Jonker
2013-04-24 10:13 ` [Buildroot] [PATCH v2 02/12] arc: Add option for ARC-specific download site Mischa Jonker
2013-04-24 10:13 ` [Buildroot] [PATCH v2 03/12] arc: Add support for ARC-specific binutils Mischa Jonker
2013-04-24 10:13 ` [Buildroot] [PATCH v2 04/12] arc: Add arc, arcbe to gnuconfig Mischa Jonker
2013-04-24 10:13 ` [Buildroot] [PATCH v2 05/12] arc: disable Crosstool-NG for ARC Mischa Jonker
2013-04-24 10:13 ` [Buildroot] [PATCH v2 06/12] arc: add gcc " Mischa Jonker
2013-04-24 10:13 ` [Buildroot] [PATCH v2 07/12] arc: Add support for ARC-specific uClibc Mischa Jonker
2013-04-24 10:13 ` [Buildroot] [PATCH v2 08/12] arc: Make sure that libgcc doesn't get included when it doesn't exist yet Mischa Jonker
2013-04-24 10:13 ` [Buildroot] [PATCH v2 09/12] kernel-headers: Use ../testing URL for kernel release candidates Mischa Jonker
2013-04-24 10:13 ` [Buildroot] [PATCH v2 10/12] kernel-headers: Add 3.9-rc8 headers to make ARC work Mischa Jonker
2013-04-24 19:41   ` Peter Korsgaard
2013-04-24 10:13 ` [Buildroot] [PATCH v2 11/12] toolchain/gcc: Only enable --with-float when it makes sense Mischa Jonker
2013-04-24 10:13 ` [Buildroot] [PATCH v2 12/12] toolchain/gcc: Introduce BR2_ARCH_HAS_NO_GCC_x_y Mischa Jonker
2013-04-25  3:02 ` [Buildroot] [PATCH v2 00/12] RFC: ARC port Thomas Petazzoni
2013-04-25 11:01   ` Mischa Jonker
2013-04-29 20:45     ` Thomas Petazzoni
2013-04-30 16:06       ` Arnout Vandecappelle
2013-04-30 22:09         ` Thomas Petazzoni [this message]
2013-05-02 14:03           ` Mischa Jonker
2013-05-02 15:12             ` Thomas Petazzoni
2013-05-02 15:18               ` Mischa Jonker
2013-05-02 16:30                 ` Thomas Petazzoni
2013-05-02 16:32             ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130501000905.609d0ced@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox