From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yann E. MORIN <yann.morin.1998@free.fr>
Date: Tue, 7 May 2013 23:05:06 +0200
Subject: [Buildroot] [PATCH v2 2/2] lockdev: add lockdev
In-Reply-To: <1367959620-17176-2-git-send-email-spenser@gillilanding.com>
References: <1367618887-25757-1-git-send-email-spenser@gillilanding.com>
 <1367959620-17176-1-git-send-email-spenser@gillilanding.com>
 <1367959620-17176-2-git-send-email-spenser@gillilanding.com>
Message-ID: <20130507210506.GD22338@free.fr>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Spenser, All,

On Tue, May 07, 2013 at 03:47:00PM -0500, Spenser Gilliland wrote:
> Add lockdev a package for locking devices.
> 
> Signed-off-by: Spenser Gilliland <spenser@gillilanding.com>
[--SNIP--]
> diff --git a/package/Config.in b/package/Config.in
> index 23af3f5..8498609 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -255,6 +255,7 @@ source "package/iostat/Config.in"
>  source "package/irda-utils/Config.in"
>  source "package/kbd/Config.in"
>  source "package/lcdproc/Config.in"
> +source "package/lockdev/Config.in"
>  source "package/lm-sensors/Config.in"

Alphabetical order, please ('o' comes after 'm', as far as I know! ;-) )

>  source "package/lshw/Config.in"
>  source "package/lsuio/Config.in"
[--SNIP--]
> diff --git a/package/lockdev/lockdev.mk b/package/lockdev/lockdev.mk
> new file mode 100644
> index 0000000..10a5929
> --- /dev/null
> +++ b/package/lockdev/lockdev.mk
> @@ -0,0 +1,30 @@
> +#############################################################
> +#
> +# lockdev
> +#
> +#############################################################
> +
> +LOCKDEV_VERSION = 1.0.3
> +LOCKDEV_SOURCE = lockdev_$(LOCKDEV_VERSION).orig.tar.gz
> +LOCKDEV_SITE = http://ftp.debian.org/debian/pool/main/l/lockdev/
> +LOCKDEV_LICENSE = LGPLv2.1
> +LOCKDEV_LICENSE_FILE = LICENSE
> +LOCKDEV_INSTALL_STAGING = YES
> +
> +define LOCKDEV_BUILD_CMDS
> +	$(MAKE1) $(TARGET_CONFIGURE_OPTS) -C $(@D) static shared
> +endef
> +
> +define LOCKDEV_INSTALL_STAGING_CMDS
> +	$(MAKE1) basedir=$(STAGING_DIR)/usr -C $(@D) install
> +	ln -sf $(STAGING_DIR)/usr/lib/liblockdev.$(LOCKDEV_VERSION).so $(STAGING_DIR)/usr/lib/liblockdev.so
> +	ln -sf $(STAGING_DIR)/usr/lib/liblockdev.$(LOCKDEV_VERSION).so $(STAGING_DIR)/usr/lib/liblockdev.so.1
> +endef
> +
> +define LOCKDEV_INSTALL_TARGET_CMDS
> +	$(MAKE1) basedir=$(TARGET_DIR)/usr -C $(@D) install
> +	ln -sf $(TARGET_DIR)/usr/lib/liblockdev.$(LOCKDEV_VERSION).so $(TARGET_DIR)/usr/lib/liblockdev.so
> +	ln -sf $(TARGET_DIR)/usr/lib/liblockdev.$(LOCKDEV_VERSION).so $(TARGET_DIR)/usr/lib/liblockdev.so.1

What is the SONAME of the library? You only need to install the library
to a file named as the SONAME, not any other symlink is required.

But of course, if "development files on target" are selected you need
the .so symlink (but devel-files-on-target this is deprecated now).

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'