Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] linux: CONFIG_KERNEL_LZO option requires host-lzop
Date: Tue, 14 May 2013 11:16:51 +0200	[thread overview]
Message-ID: <20130514111651.0c61cb24@skate> (raw)
In-Reply-To: <CAHkwnC_KQ30thPqy3WA3wGpOipMfmf6rk-HY78sf=Dus8F9ExQ@mail.gmail.com>

Dear Fabio Porcedda,

On Tue, 14 May 2013 11:02:32 +0200, Fabio Porcedda wrote:

> I know that the best solution is to depend on the linux kernel
> configuration, but I don't know a way to do that cleanly.
> Maybe some clever idea?
> 
> Adding mandatory dependency is the simplest and always works but as
> you pointed it always builds host-lzop even when is not used.
> 
> Choosing the compression within buildroot doesn't wok when using a
> defconfig or linux-xconfig target but at least does build host-lzop
> only when is used.

It does work, as long as the compression type is enforced by Buildroot,
regardless of what was selected by linux-xconfig or the defconfig.
That's what we do today for DEVTMPFS/DEVTMPFS_MOUNT/INITRAMFS_SOURCE
for example.

However, before going ahead and implementing that, I'd like to have the
opinion of Peter and maybe others.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-05-14  9:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-13  7:58 [Buildroot] [PATCH] linux: CONFIG_KERNEL_LZO option requires host-lzop Fabio Porcedda
2013-05-13  8:04 ` Thomas Petazzoni
2013-05-14  9:02   ` Fabio Porcedda
2013-05-14  9:16     ` Thomas Petazzoni [this message]
2013-05-14 15:30       ` Peter Korsgaard
2013-05-14 15:31 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130514111651.0c61cb24@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox