Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] poco: not available for all architectures
Date: Thu, 16 May 2013 14:54:53 +0300	[thread overview]
Message-ID: <20130516115453.GF4709@tarshish> (raw)
In-Reply-To: <1368704401-1832-1-git-send-email-gustavo@zacarias.com.ar>

Hi Gustavo,

On Thu, May 16, 2013 at 08:40:01AM -0300, Gustavo Zacarias wrote:
> Missing defines for:
> aarch64, arc, blackfin, microblaze & xtensa.
> Not properly supported: mips - only defines generic mips as BE, doesn't
> know about mipsel (LE) thus assuming it's BE.
> Fixes:
> http://autobuild.buildroot.net/results/9847702b046bed59b07f0e075a58b1f31e9236ce/
> 
> This should be pretty straightforward to fix in
> Foundation/include/Poco/Platform.h for interested parties since it only
> cares about endianness.
> 
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
>  package/poco/Config.in | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/poco/Config.in b/package/poco/Config.in
> index b823071..402f96d 100644
> --- a/package/poco/Config.in
> +++ b/package/poco/Config.in
> @@ -3,6 +3,7 @@ config BR2_PACKAGE_POCO
>  	depends on BR2_INSTALL_LIBSTDCPP
>  	depends on BR2_USE_WCHAR
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	depends on !(BR2_aarch64 || BR2_arc || BR2_bfin || BR2_microblaze || BR2_mipsel || BR2_xtensa)
>  	select BR2_PACKAGE_ZLIB
>  	select BR2_PACKAGE_PCRE
>  	help
> @@ -61,3 +62,4 @@ endif # BR2_PACKAGE_POCO
>  comment "poco requires a toolchain with WCHAR, threads, and C++ support"
>  	depends on !BR2_USE_WCHAR || !BR2_INSTALL_LIBSTDCPP \
>  		|| !BR2_TOOLCHAIN_HAS_THREADS
> +	depends on !(BR2_aarch64 || BR2_arc || BR2_bfin || BR2_microblaze || BR2_mipsel || BR2_xtensa)

Enabling this comment when it is the architecture that is not supported might 
confuse the user. Maybe we should add another comment? How is this handled in 
other packages?

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2013-05-16 11:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-16 11:40 [Buildroot] [PATCH] poco: not available for all architectures Gustavo Zacarias
2013-05-16 11:54 ` Baruch Siach [this message]
2013-05-16 12:02   ` Gustavo Zacarias
2013-05-16 12:05     ` Baruch Siach
2013-05-16 12:07       ` Gustavo Zacarias
2013-05-16 12:23     ` Thomas Petazzoni
2013-05-16 12:25       ` Gustavo Zacarias
2013-05-16 12:41         ` Thomas Petazzoni
2013-05-23 21:36 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130516115453.GF4709@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox