From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 04/12] lbase64: New package
Date: Mon, 20 May 2013 16:52:04 +0200 [thread overview]
Message-ID: <20130520165204.0269d05a@skate> (raw)
In-Reply-To: <1369054604-26139-4-git-send-email-shmuelzon@gmail.com>
Dear Assaf Inbal,
On Mon, 20 May 2013 15:56:36 +0300, Assaf Inbal wrote:
> +define LBASE64_BUILD_CMDS
> + $(MAKE) -C $(@D) CC="$(TARGET_CC)" CFLAGS="$(TARGET_CFLAGS) -fPIC" so
> +endef
Using $(TARGET_CONFIGURE_OPTS) here would be better if possible.
Also, we're normally supposed to handle both the shared library and
static library build. Ideally, when BR2_PREFER_STATIC_LIB is disabled,
build both the shared and the static library, and when
BR2_PREFER_STATIC_LIB is enabled, build only the static library.
> +
> +define LBASE64_INSTALL_TARGET_CMDS
> + $(INSTALL) "$(@D)/base64.so" "$(TARGET_DIR)/usr/lib/lua"
> +endef
We normally don't quote file paths, and we use the following syntax:
$(INSTALL) -D $(@D)/base64.so $(TARGET_DIR)/usr/lib/lua/base64.so
Thanks,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-05-20 14:52 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 12:56 [Buildroot] [PATCH 01/12] coxpcall: Updated source location Assaf Inbal
2013-05-20 12:56 ` [Buildroot] [PATCH 02/12] luasocket: Update " Assaf Inbal
2013-06-16 19:47 ` Peter Korsgaard
2013-06-17 5:18 ` Assaf Inbal
2013-05-20 12:56 ` [Buildroot] [PATCH 03/12] sqlite: Added host compilation support Assaf Inbal
2013-05-20 13:26 ` Yann E. MORIN
2013-05-20 14:27 ` Assaf Inbal
2013-05-20 16:00 ` Yann E. MORIN
2013-05-20 12:56 ` [Buildroot] [PATCH 04/12] lbase64: New package Assaf Inbal
2013-05-20 14:52 ` Thomas Petazzoni [this message]
2013-05-20 15:23 ` Assaf Inbal
2013-05-20 17:25 ` Thomas Petazzoni
2013-05-22 6:19 ` Arnout Vandecappelle
2013-05-22 6:55 ` Assaf Inbal
2013-05-22 7:28 ` Thomas Petazzoni
2013-05-22 7:01 ` Thomas Petazzoni
2013-05-22 7:06 ` Arnout Vandecappelle
2013-05-22 7:29 ` Bryan Hundven
2013-05-22 7:42 ` Thomas Petazzoni
2013-05-22 7:46 ` Bryan Hundven
2013-05-22 7:30 ` Thomas Petazzoni
2013-05-20 16:00 ` François Perrad
2013-06-16 19:52 ` Peter Korsgaard
2013-06-17 5:31 ` Assaf Inbal
2013-06-17 20:59 ` Peter Korsgaard
2013-05-20 12:56 ` [Buildroot] [PATCH 05/12] lua-ev: " Assaf Inbal
2013-05-20 16:05 ` François Perrad
2013-06-16 19:53 ` Peter Korsgaard
2013-06-17 5:58 ` Assaf Inbal
2013-06-17 21:14 ` Peter Korsgaard
2013-05-20 12:56 ` [Buildroot] [PATCH 06/12] luabitop: " Assaf Inbal
2013-06-16 20:03 ` Peter Korsgaard
2013-05-20 12:56 ` [Buildroot] [PATCH 07/12] luacrypto: " Assaf Inbal
2013-05-20 16:07 ` François Perrad
2013-06-16 20:16 ` Peter Korsgaard
2013-06-17 6:18 ` Assaf Inbal
2013-06-17 21:18 ` Peter Korsgaard
2013-05-20 12:56 ` [Buildroot] [PATCH 08/12] luaexpatutils: " Assaf Inbal
2013-06-19 21:24 ` Peter Korsgaard
2013-05-20 12:56 ` [Buildroot] [PATCH 09/12] luaposix: " Assaf Inbal
2013-05-20 16:09 ` François Perrad
2013-06-19 21:34 ` Peter Korsgaard
2013-06-20 4:45 ` Assaf Inbal
2013-06-20 5:57 ` Arnout Vandecappelle
2013-06-20 6:10 ` Thomas Petazzoni
2013-06-20 7:05 ` Assaf Inbal
2013-06-20 7:39 ` Assaf Inbal
2013-06-20 7:46 ` Thomas Petazzoni
2013-05-20 12:56 ` [Buildroot] [PATCH 10/12] luasec: " Assaf Inbal
2013-05-20 16:10 ` François Perrad
2013-08-12 17:46 ` Thomas Petazzoni
2013-05-20 12:56 ` [Buildroot] [PATCH 11/12] luasql: " Assaf Inbal
2013-05-20 16:13 ` François Perrad
2013-08-12 17:47 ` Thomas Petazzoni
2013-05-20 12:56 ` [Buildroot] [PATCH 12/12] orbit: " Assaf Inbal
2013-08-13 9:53 ` Thomas Petazzoni
2013-08-13 10:16 ` Assaf Inbal
2013-06-16 19:46 ` [Buildroot] [PATCH 01/12] coxpcall: Updated source location Peter Korsgaard
2013-06-17 5:17 ` Assaf Inbal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130520165204.0269d05a@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox