Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v7 01/10] libglib2: Bump libglib2 to 2.36.1
Date: Wed, 22 May 2013 19:30:35 +0200	[thread overview]
Message-ID: <20130522173035.GA14196@free.fr> (raw)
In-Reply-To: <CAEBucnA3xso9se45tc7EYb1zsPYTQnLk7WHjiKrowJFm7uqkkw@mail.gmail.com>

Spenser, Thomas, All,

On 2013-05-22 10:57 -0500, Spenser Gilliland spake thusly:
> > Is there any reason for bumping libglib2, glibmm and glib-networking in
> > the same patch? I seem to recall in earlier versions of your patch
> > series, you had separate patches for those bumps.
> 
> Case 1 is correct.  I was trying to make the patch bisect-able.  It's
> possible that glibmm and glib-networking would fail to build if the
> version is not consistent.

Thomas, that was me pointing out that bumping glib2, glibmm and
glib-networking separately might be an error, and IIRC Spenser confirmed
that with a test build (discussed on IRC some days ago).

Spenser, to avoid confusion in the future:
  - add the relevant commenter as Cc: in the commit log,
  - and add a little history to your patch commit log, like:

    blabla: do the foo

    Some explanations
    possibly on
    multiple lines

    Signed-off-by: you
    Cc: someone
    Cc: someone else
    ---
    v2 -> v3:
      - fix this and that (someone else)
    v1 -> v2:
      - tweak this and that (someone)

So the reviewer know what has changed when you resend your patch(es).

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2013-05-22 17:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-21 23:10 [Buildroot] [PATCH v7 00/10] add Gstreamer 1.X for gst-omx support Spenser Gilliland
2013-05-21 23:10 ` [Buildroot] [PATCH v7 01/10] libglib2: Bump libglib2 to 2.36.1 Spenser Gilliland
2013-05-22  6:55   ` Thomas Petazzoni
2013-05-22 15:57     ` Spenser Gilliland
2013-05-22 17:30       ` Yann E. MORIN [this message]
2013-05-22 18:01         ` Thomas Petazzoni
2013-05-26  9:26   ` Thomas Petazzoni
2013-05-21 23:10 ` [Buildroot] [PATCH v7 02/10] gstreamer1: Add gstreamer version 1.0.7 package Spenser Gilliland
2013-05-21 23:10 ` [Buildroot] [PATCH v7 03/10] gst1-plugins-base: add gstreamer1 base plugins Spenser Gilliland
2013-05-21 23:10 ` [Buildroot] [PATCH v7 04/10] gst1-plugins-good: add gstreamer1 good plugins Spenser Gilliland
2013-05-21 23:10 ` [Buildroot] [PATCH v7 05/10] gst1-plugins-bad: add gstreamer1 bad plugins Spenser Gilliland
2013-05-21 23:11 ` [Buildroot] [PATCH v7 06/10] gst1-plugins-ugly: add gstreamer1 ugly plugins Spenser Gilliland
2013-05-21 23:11 ` [Buildroot] [PATCH v7 07/10] libvpx: new package libvpx Spenser Gilliland
2013-05-21 23:11 ` [Buildroot] [PATCH v7 08/10] gst1-plugins-good: add libvpx support Spenser Gilliland
2013-05-21 23:11 ` [Buildroot] [PATCH v7 09/10] libopenmax: Add libopenmax virtual package Spenser Gilliland
2013-05-21 23:11 ` [Buildroot] [PATCH v7 10/10] gst-omx: add gst-omx package Spenser Gilliland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130522173035.GA14196@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox