From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Thu, 23 May 2013 12:32:08 +0200 Subject: [Buildroot] [PATCH] package/attr: fix building out-of-tree In-Reply-To: <1369304728-21798-1-git-send-email-yann.morin.1998@free.fr> References: <1369304728-21798-1-git-send-email-yann.morin.1998@free.fr> Message-ID: <20130523123208.57177273@skate> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear Yann E. MORIN, On Thu, 23 May 2013 12:25:28 +0200, Yann E. MORIN wrote: > From: "Yann E. MORIN" > > This needs touching a m4 macro, so requires autoreconf. > > But since this is not a true autotools-package, autoreconf whines > about missing macros. So we have to explicitly pass '-I m4'. > > But since this is not a true autotools-package, the build then fails > with missing definition for _() as the configure scripts gets confused. > So, we just call autoconf, not autoreconf. If it's not a true autotools-package, then it shouldn't be using the autotools-package infrastructure, I'd say. And making a change to the source code at the configure step (such as autoconf or autoreconf) is fundamentally going into the wrong direction with regard to out-of-tree support. All steps until configure are done only once, on the source tree, and then all steps starting from the configure step are done for both the target build and the host build. Therefore, autoreconf/autoconf should not be part of the configure step anymore. I'm sending an e-mail about that in a moment. Best regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com