Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] system/device-table: do not set /home/default stgid
Date: Sat, 25 May 2013 22:37:11 +0200	[thread overview]
Message-ID: <20130525203711.GA3407@free.fr> (raw)
In-Reply-To: <1369514012-19606-1-git-send-email-yann.morin.1998@free.fr>

All,

On 2013-05-25 22:33 +0200, Yann E. MORIN spake thusly:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> 
> Currently, /home/default is mode 2755 which means it is setgid.
> Since /home/default is not group-writable, it is useless.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> 
> ---
> AFAICS, there is no reason that /home/default be setgid.
> However, I have not audited all packages to check whether one
> would require that.
> ---
>  system/device_table.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/system/device_table.txt b/system/device_table.txt
> index 421728b..43c0cfa 100644
> --- a/system/device_table.txt
> +++ b/system/device_table.txt
> @@ -9,7 +9,7 @@
>  /dev					d	755	0	0	-	-	-	-	-
>  /tmp					d	1777	0	0	-	-	-	-	-
>  /etc					d	755	0	0	-	-	-	-	-
> -/home/default				d	2755	1000	1000	-	-	-	-	-
> +/home/default				d	755	1000	1000	-	-	-	-	-
>  /var/www				d	755	33	33	-	-	-	-	-
>  /etc/shadow				f	600	0	0	-	-	-	-	-
>  /etc/passwd				f	644	0	0	-	-	-	-	-

I think this should got in -next, not master. If it should go at all.

Any reason for this setgid bit on a group-unwritable directory in the
first place?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2013-05-25 20:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-25 20:33 [Buildroot] [PATCH] system/device-table: do not set /home/default stgid Yann E. MORIN
2013-05-25 20:37 ` Yann E. MORIN [this message]
2013-05-26 17:23   ` Samuel Martin
2013-05-30 14:06 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130525203711.GA3407@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox