From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Revert "dependencies: check that SSL certificates are installed"
Date: Sun, 26 May 2013 10:27:18 +0200 [thread overview]
Message-ID: <20130526102718.5b837ab4@skate> (raw)
In-Reply-To: <20130526082436.GF5037@tarshish>
Dear Baruch Siach,
On Sun, 26 May 2013 11:24:36 +0300, Baruch Siach wrote:
> > Well, d66cd067f3 was written because if you install a very minimal
> > system, you may not have the SSL certificates installed, which prevents
> > any download from https:// website. So I added a quick check for that.
>
> How about adding a config option (disabled by default) that adds
> --no-check-certificate to the wget command? We may event monitor the wget exit
> status and advice the user to enable this options when we see the status = 5
> (SSL verification failure).
Hum, I believe it's not very wise to encourage users to use
--no-check-certificate.
> > However, apparently, the location of such certificates is not fixed
> > between various systems, so clearly my patch doesn't work properly.
>
> Well, 'openssl version -d' does give you the default location where OpenSSL
> expects certificates to be. However, as I said in the commit log, the presence
> of this directory doesn't necessarily mean that you actually have any
> certificate in this location. On Debian if you uninstall ca-certificates
> you'll still have /etc/ssh/certs.
Ok.
> > So, for now, I believe option (1) is the only viable one, unless there
> > is some local command that allows to check whether SSL certificates are
> > installed or not.
>
> So is this an Acked-by from you?
Yes:
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-05-26 8:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 6:27 [Buildroot] [PATCH] Revert "dependencies: check that SSL certificates are installed" Baruch Siach
2013-05-26 2:47 ` Baruch Siach
2013-05-26 3:21 ` Spenser Gilliland
2013-05-26 7:49 ` Thomas Petazzoni
2013-05-26 8:24 ` Baruch Siach
2013-05-26 8:27 ` Thomas Petazzoni [this message]
2013-05-26 9:14 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130526102718.5b837ab4@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox