Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] infra: allow running 'make clean menuconfig ; make *-menuconfig'
Date: Mon, 27 May 2013 11:23:45 +0200	[thread overview]
Message-ID: <20130527112345.1741b563@skate> (raw)
In-Reply-To: <1369645352-11942-1-git-send-email-s.martin49@gmail.com>

Dear Samuel Martin,

On Mon, 27 May 2013 11:02:32 +0200, Samuel Martin wrote:

> +# Inconditionnaly add host-ccache dependency when BR2_CCACHE is enabled.
> +# This allows to run the following without failing on test the compiler
> +# because the ccache binary is not yet built:
> +#
> +# $ make clean menuconfig
> +# $ make [linux|ctng|uclibc|barebox|busybox]-menuconfig
> +ifeq ($(BR2_CCACHE),y)
> +ifneq ($(1),host-ccache)
> +$(2)_DEPENDENCIES += host-ccache
> +endif
> +endif

I am not sure we want to make this specific to the ccache problem. The
linux-menuconfig target also needs to depend on "dirs" so that the base
directories need to be created.

Shouldn't we depend on something like $(BASE_TARGETS) instead, which
will then contain "host-ccache dirs", and everything that's needed?
Also, all packages depend on the toolchain (but beware, binutils is
also a package, and is part of the toolchain).

So just like everything in the core infrastructure: I don't want a
patch that just fixes the particular problem of this bug by adding more
crap. I want something that clarifies the dependency of packages on
"base" things, and makes it work properly.

Thanks,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

      reply	other threads:[~2013-05-27  9:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-27  9:02 [Buildroot] [PATCH 1/1] infra: allow running 'make clean menuconfig ; make *-menuconfig' Samuel Martin
2013-05-27  9:23 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130527112345.1741b563@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox