Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] lttng-babeltrace: fix build failure on gcc14
Date: Tue, 28 May 2013 15:32:43 +0200	[thread overview]
Message-ID: <20130528153243.04176f08@skate> (raw)
In-Reply-To: <87sj179qrd.fsf@dell.be.48ers.dk>

Dear Peter Korsgaard,

On Tue, 28 May 2013 15:29:42 +0200, Peter Korsgaard wrote:

>  Thomas> +# We patch configure.ac to fix a problem that appears
>  Thomas> +# only with some old host gcc
>  Thomas> +HOST_LTTNG_BABELTRACE_AUTORECONF = YES
> 
> The patch also gets applied for target builds. Don't we need to
> autoreconf there as well?

I was focused on the host gcc problem, but if the user decides to use
an old gcc as the cross-compiler, then there may be the same issue.

And anyway, patching configure.ac without doing the autoreconf means
that at build time, the thing will notice that configure.ac is more
recent than configure, and will do some kind of autoreconf.

So yes, adding LTTNG_BABELTRACE_AUTORECONF = YES is probably a good
thing to do.

BTW:

 * I've submitted the patch upstream. See
   http://lists.lttng.org/pipermail/lttng-dev/2013-May/020542.html and
   http://lists.lttng.org/pipermail/lttng-dev/2013-May/020543.html.

 * This host/target difference on autoreconf will disappear with the
   out-of-tree stuff, since we'll have only one source tree.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

      reply	other threads:[~2013-05-28 13:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-28 13:22 [Buildroot] [PATCH] lttng-babeltrace: fix build failure on gcc14 Thomas Petazzoni
2013-05-28 13:29 ` Peter Korsgaard
2013-05-28 13:32   ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130528153243.04176f08@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox