Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] host-gutenprint
Date: Wed, 29 May 2013 13:56:24 +0200	[thread overview]
Message-ID: <20130529135624.75b9b699@skate> (raw)
In-Reply-To: <CALdGskKLCjz1Bo6R1eBWdwf5xKXgpQ12uHGvYaE74vZ2XpjhNw@mail.gmail.com>

Dear Olivier Schonken,

Please use the Buildroot mailing list for such discussion. I've added
it in Cc.

On Wed, 29 May 2013 10:47:43 +0200, Olivier Schonken wrote:

> I tried to sort out the
> http://autobuild.buildroot.org/results/8f1/8f1da2d88bbfc75ca67d704f6529377746f3f66e/build-end.log
> 
> problem a while ago.  The easiest solution is to patch the Makefile.am of
> the host-gutenprint to make it not enter the cups directory and run the
> cups makefile.
> 
> The problem I encountered is that the host-gutenprint-001.patch also gets
> applied to the gutenprint package, and thus the cups driver will not be
> built for the target. I couldn't get buildroot to distinguish between a
> host-build and a target-build patch.
> 
> If you have any ideas on how to go about this, I'll be happy to implement.

You should *not* distinguish between host patches and target patches.
This is really bad as the source tree should be the same for the host
and the target builds, and I've sent just two days ago a patch series
that was precisely fixing the packages that are currently doing this.

So, what you should is instead add an option like --disable-cups in the
configure.ac, which defaults to enabled, and in the Makefile.am, only
add the cups sub-directory to the SUBDIRS variable if CUPS is enabled.
Preferably, it should be done in a form that allows the patch to be
submitted upstream.

You can look at
http://lists.gnu.org/archive/html/bug-gettext/2013-05/msg00035.html for
an example I've submitted upstream to gettext.

Note that apparently, gutenprint already has a --without-cups option.
So maybe your work is really to figure out why this option doesn't
disable the CUPS build.

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

       reply	other threads:[~2013-05-29 11:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CALdGskKLCjz1Bo6R1eBWdwf5xKXgpQ12uHGvYaE74vZ2XpjhNw@mail.gmail.com>
2013-05-29 11:56 ` Thomas Petazzoni [this message]
2013-05-30  7:35   ` [Buildroot] host-gutenprint Lionel Orry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130529135624.75b9b699@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox