Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] arch: define appropriate ld emulation values for the MIPS architecture
Date: Thu, 6 Jun 2013 10:57:30 +0200	[thread overview]
Message-ID: <20130606105730.3682f59e@skate> (raw)
In-Reply-To: <CAG2jQ8hOtBgc9ULF0KxmWrem60zRBqO8CKGFVEsL_02QsK6iZg@mail.gmail.com>

Dear Markos Chandras,

On Thu, 6 Jun 2013 09:37:41 +0100, Markos Chandras wrote:

> binutils set el32{l,b}smipn32 as default ABI for MIPS64 as well. The
> elf64{l,b}tsmip one need to be used only if you want to use the n64
> ABI. My opinion is that this patch needs to be changed to something
> like this:
> 
>  +config BR2_LD_TARGET_EMULATION
>  +       default "elf64ltsmip"      if BR2_mips64el && BR2_MIPS_NABI64
>  +       default "elf64btsmip"      if BR2_mips64 && BR2_MIPS_NABI64
>  +       default "elf32ltsmip"      if BR2_mipsel && !BR2_MIPS_NABI32
>  +       default "elf32btsmip"      if BR2_mips && !BR2_MIPS_NABI32
>  +       default "elf32ltsmipn32"   if BR2_mipsel && BR2_MIPS_NABI32
>  +       default "elf32btsmipn32"   if BR2_mips && BR2_MIPS_NABI32

Ok, but I'm not too happy with the fact that the BR2_mips64[el]
&& !BR2_MIPS_NABI64 is not being handled here. And according to
arch/Config.in.mips, in fact the n32 ABI does not make sense on 32 bits
BR2_mips and BR2_mipsel.

So, shouldn't this thing be:

config BR2_LD_TARGET_EMULATION
	default "elf64ltsmip"		if  BR2_mips64el && BR2_MIPS_NABI64
	default "elf64btsmip"		if  BR2_mips64   && BR2_MIPS_NABI64
	default "elf32ltsmipn32"	if  BR2_mips64el && BR2_MIPS_NABI32
	default "elf32btsmipn32"	if  BR2_mips64   && BR2_MIPS_NABI32
	default "elf32ltsmip"		if (BR2_mips64el && BR2_MIPS_OABI32) || BR2_mipsel
	default "elf32btsmip"		if (BR2_mips64   && BR2_MIPS_OABI32) || BR2_mips

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-06-06  8:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-05 21:59 [Buildroot] [PATCH 1/2] toolchain: wrap 'ld' so that a ld emulation can be specified Thomas Petazzoni
2013-06-05 21:59 ` [Buildroot] [PATCH 2/2] arch: define appropriate ld emulation values for the MIPS architecture Thomas Petazzoni
2013-06-06  8:37   ` Markos Chandras
2013-06-06  8:57     ` Thomas Petazzoni [this message]
2013-06-06  9:04       ` Markos Chandras
2013-06-06  8:31 ` [Buildroot] [PATCH 1/2] toolchain: wrap 'ld' so that a ld emulation can be specified Markos Chandras
2013-06-06  8:51   ` Thomas Petazzoni
2013-06-06  8:56     ` Markos Chandras
2013-06-06  9:13       ` Markos Chandras
2013-06-06 10:04         ` Markos Chandras
  -- strict thread matches above, loose matches on Subject: below --
2016-02-20  9:33 Jan Heylen
2016-02-20  9:33 ` [Buildroot] [PATCH 2/2] arch: define appropriate ld emulation values for the MIPS architecture Jan Heylen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130606105730.3682f59e@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox