Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv3 ] python3: Port python2 patches to reduce the interpreter size
Date: Fri, 7 Jun 2013 10:57:19 +0200	[thread overview]
Message-ID: <20130607085719.GH14209@lukather> (raw)
In-Reply-To: <20130529171711.412e5b4c@skate>

Hi Thomas,

On Wed, May 29, 2013 at 05:17:11PM +0200, Thomas Petazzoni wrote:
> On Wed, 29 May 2013 16:56:47 +0200, Samuel Martin wrote:
> > I've run few builds (same config, with all or no modules selected,
> > with/without this patch applied):
> > -rw-r--r-- 1 sam sam 64M May 29 12:39
> > br-output/python-without-patch/images/rootfs.tar
> > -rw-r--r-- 1 sam sam 29M May 29 12:50
> > br-output/python-with-patch-v3-no-modules/images/rootfs.tar
> > -rw-r--r-- 1 sam sam 32M May 29 12:49
> > br-output/python-with-patch-v3-all-modules/images/rootfs.tar
> 
> I would have expected this 32M to be much closer to the 64M. Normally,
> with all modules enabled, we should have the same size as the Python
> interpreter without Maxime's patch.
> 
> Or am I missing something?

To be honest, I don't recall much about this 6-monthes-old patch.

What I recall however is that it removed a significant size notably
because we don't integrate the python unittests *at all*. And they were
taking a significant space.

I'd say that this patch reduces drastically the size of the interpreter
without adding extra bugs (at least none that we caught so far). So
maybe we can just merge this patch, close the bug, and if someone's
willing to improve the situation, he can still step up and send
additional patches.

Maxime

  reply	other threads:[~2013-06-07  8:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-29  8:36 [Buildroot] [PATCHv3 ] python3: Port python2 patches to reduce the interpreter size Maxime Ripard
2013-05-29 14:56 ` Samuel Martin
2013-05-29 15:17   ` Thomas Petazzoni
2013-06-07  8:57     ` Maxime Ripard [this message]
2013-06-07  9:52       ` Samuel Martin
2013-06-07 10:09         ` Maxime Ripard
2013-06-29  8:22 ` Peter Korsgaard
2013-07-01 19:29   ` Danomi Manchego
2013-07-02  9:02     ` Peter Korsgaard
2013-07-03  9:20     ` Maxime Ripard
2013-07-03 14:18       ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130607085719.GH14209@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox