From mboxrd@z Thu Jan  1 00:00:00 1970
From: Baruch Siach <baruch@tkos.co.il>
Date: Fri, 14 Jun 2013 11:24:37 +0300
Subject: [Buildroot] [PATCH 1/1] New package: libqrencode
In-Reply-To: <1371197197-16323-1-git-send-email-phil@zankapfel.net>
References: <1371197197-16323-1-git-send-email-phil@zankapfel.net>
Message-ID: <20130614082437.GB4312@tarshish>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Hi Phil,

Thanks for contributing. A couple of comments below.

On Fri, Jun 14, 2013 at 10:06:37AM +0200, Phil Eichinger wrote:
> 
> Signed-off-by: Phil Eichinger <phil@zankapfel.net>
> ---

[...]

> diff --git a/package/libqrencode/libqrencode.mk 
> b/package/libqrencode/libqrencode.mk
> new file mode 100644
> index 0000000..121fd86
> --- /dev/null
> +++ b/package/libqrencode/libqrencode.mk
> @@ -0,0 +1,20 @@
> +#############################################################
> +#
> +# libqrencode
> +#
> +#############################################################
> +
> +LIBQRENCODE_VERSION = 3.4.2
> +LIBQRENCODE_SOURCE = qrencode-$(LIBQRENCODE_VERSION).tar.gz

This the default, you can remove this line.

> +LIBQRENCODE_SITE = http://fukuchi.org/works/qrencode
> +LIBQRENCODE_DEPENDENCIES = libpng
> +LIBQRENCODE_LICENSE = GPLv2+

The web page and README/COPYING file say the license is LGPLv2.1+. 

> +LIBQRENCODE_LICENSE_FILES = COPYING
> +
> +ifeq ($(BR2_PACKAGE_LIBQRENCODE_TOOLS),y)
> +        LIBQRENCODE_CONF_OPT += --with-tools=yes
> +else
> +        LIBQRENCODE_CONF_OPT += --with-tools=no
> +endif
> +
> +$(eval $(autotools-package))

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -