From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v11 09/11] multimedia: reorganize for gst1
Date: Thu, 20 Jun 2013 09:54:56 +0200 [thread overview]
Message-ID: <20130620095456.1bac20d0@skate> (raw)
In-Reply-To: <1371701651-7739-10-git-send-email-spenser@gillilanding.com>
Dear Spenser Gilliland,
On Wed, 19 Jun 2013 23:14:08 -0500, Spenser Gilliland wrote:
>
> Signed-off-by: Spenser Gilliland <spenser@gillilanding.com>
> ---
> package/multimedia/Config.in | 19 ++++++++++++-------
> 1 file changed, 12 insertions(+), 7 deletions(-)
>
> diff --git a/package/multimedia/Config.in b/package/multimedia/Config.in
> index 292d029..925051e 100644
> --- a/package/multimedia/Config.in
> +++ b/package/multimedia/Config.in
> @@ -5,22 +5,27 @@ source "package/multimedia/bellagio/Config.in"
> source "package/multimedia/faad2/Config.in"
> source "package/multimedia/flac/Config.in"
> source "package/multimedia/ffmpeg/Config.in"
> +
> +# Gstreamer 0.10.x & Plugins
> source "package/multimedia/gstreamer/Config.in"
> -source "package/multimedia/gstreamer1/Config.in"
> +source "package/multimedia/gst-plugins-base/Config.in"
> +source "package/multimedia/gst-plugins-good/Config.in"
> +source "package/multimedia/gst-plugins-bad/Config.in"
> +source "package/multimedia/gst-plugins-ugly/Config.in"
> source "package/multimedia/gst-ffmpeg/Config.in"
> source "package/multimedia/gst-dsp/Config.in"
> source "package/multimedia/gst-fsl-plugins/Config.in"
> source "package/multimedia/gst-omapfb/Config.in"
> -source "package/multimedia/gst-omx/Config.in"
> -source "package/multimedia/gst-plugins-base/Config.in"
> +source "package/multimedia/gst-plugin-x170/Config.in"
> +
> +# Gstreamer 1.x & Plugins
> +source "package/multimedia/gstreamer1/Config.in"
> source "package/multimedia/gst1-plugins-base/Config.in"
> -source "package/multimedia/gst-plugins-good/Config.in"
> source "package/multimedia/gst1-plugins-good/Config.in"
> -source "package/multimedia/gst-plugins-bad/Config.in"
> source "package/multimedia/gst1-plugins-bad/Config.in"
> -source "package/multimedia/gst-plugins-ugly/Config.in"
> source "package/multimedia/gst1-plugins-ugly/Config.in"
> -source "package/multimedia/gst-plugin-x170/Config.in
> +source "package/multimedia/gst-omx/Config.in"
> +
> source "package/multimedia/lame/Config.in"
> source "package/multimedia/libvpx/Config.in"
> source "package/multimedia/madplay/Config.in"
I think this organization is good, but I wonder why it's not done when
the packages are introduced. I.e, the patch adding gstreamer1 should do:
+# GStreamer 1.x & Plugins
+source "package/multimedia/gstreamer1/Config.in"
Then, the patch adding the base plugins should do:
+source "package/multimedia/gst1-plugins-base/Config.in"
But, ok, I'm nitpicking here :)
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-06-20 7:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 4:13 [Buildroot] [PATCH v11 00/11] add Gstreamer 1.X for gst-omx support Spenser Gilliland
2013-06-20 4:14 ` [Buildroot] [PATCH v11 01/11] gstreamer1: Add gstreamer version 1.1.1 package Spenser Gilliland
2013-06-20 6:09 ` Arnout Vandecappelle
2013-06-20 12:49 ` Peter Korsgaard
2013-06-20 4:14 ` [Buildroot] [PATCH v11 02/11] gstreamer: update for gstreamer1 Spenser Gilliland
2013-06-20 12:51 ` Peter Korsgaard
2013-06-20 4:14 ` [Buildroot] [PATCH v11 03/11] gst1-plugins-base: add gstreamer1 base plugins Spenser Gilliland
2013-06-20 6:20 ` Arnout Vandecappelle
2013-06-20 4:14 ` [Buildroot] [PATCH v11 04/11] gst1-plugins-good: add gstreamer1 good plugins Spenser Gilliland
2013-06-20 4:14 ` [Buildroot] [PATCH v11 05/11] gst1-plugins-bad: add gstreamer1 bad plugins Spenser Gilliland
2013-06-20 4:14 ` [Buildroot] [PATCH v11 06/11] gst1-plugins-ugly: add gstreamer1 ugly plugins Spenser Gilliland
2013-06-20 4:14 ` [Buildroot] [PATCH v11 07/11] gst1-plugins-good: add libvpx support Spenser Gilliland
2013-06-20 4:14 ` [Buildroot] [PATCH v11 08/11] gst-omx: add gst-omx package Spenser Gilliland
2013-06-20 4:14 ` [Buildroot] [PATCH v11 09/11] multimedia: reorganize for gst1 Spenser Gilliland
2013-06-20 7:54 ` Thomas Petazzoni [this message]
2013-06-20 19:37 ` Spenser Gilliland
2013-06-21 7:00 ` Thomas Petazzoni
2013-06-20 4:14 ` [Buildroot] [PATCH v11 10/11] libav: add new package Spenser Gilliland
2013-06-20 4:14 ` [Buildroot] [PATCH v11 11/11] gst-libav: add libav plugin for gtreamer 1.x Spenser Gilliland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130620095456.1bac20d0@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox