Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/libdvbsi: new package
Date: Sun, 23 Jun 2013 16:42:35 +0200	[thread overview]
Message-ID: <20130623164235.01e695fc@skate> (raw)
In-Reply-To: <1371998097-27155-1-git-send-email-c.schoenert@gmail.com>

Dear Carsten Schoenert,

On Sun, 23 Jun 2013 16:34:56 +0200, Carsten Schoenert wrote:

> --- /dev/null
> +++ b/package/libdvbsi/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_LIBDVBSI
> +	bool "libdvbsi"
> +	depends on BR2_INSTALL_LIBSTDCPP && BR2_USE_WCHAR && BR2_TOOLCHAIN_HAS_THREADS

We generally put these dependencies each on a separate line, for some
reason.

> +	help
> +	  C++ parsing library for Service Information (SI) in DVB systems.
> +	  With libdvbsi++ you can convert raw DVB service information to
> +	  a set of C++ objects, removing the need to parse data manually.
> +
> +	  http://www.saftware.de/

Missing comment when the package cannot be selected due to the absence
of the toolchain dependencies.


> +LIBDVBSI_VERSION = 0.3.6
> +LIBDVBSI_SOURCE = libdvbsi++-$(LIBDVBSI_VERSION).tar.bz2
> +LIBDVBSI_SITE = http://www.saftware.de/
> +LIBDVBSI_INSTALL_STAGING = YES
> +LIBDVBSI_LICENSE = LGPLv2.1
> +LIBDVBSI_LICENSE_FILE = COPYING
> +
> +# sometimes no Makefile is in the archive
> +LIBDVBSI_AUTORECONF=YES
> +
> +$(eval $(autotools-package))

Otherwise, looks good.

Thanks,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-06-23 14:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-23 14:34 [Buildroot] [PATCH] package/libdvbsi: new package Carsten Schoenert
2013-06-23 14:42 ` Thomas Petazzoni [this message]
2013-06-23 15:02   ` Carsten Schoenert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130623164235.01e695fc@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox