Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] Some issues found while trying to add JimTcl to buildroot
Date: Tue, 25 Jun 2013 21:20:43 +0200	[thread overview]
Message-ID: <20130625212043.3d224da3@skate> (raw)
In-Reply-To: <CALF0-+V5oWQ_zo6pzs8WOEj02H2Q9W7rzBvioabK0u_nuAaXDg@mail.gmail.com>

Dear Ezequiel Garcia,

On Tue, 25 Jun 2013 15:23:56 -0300, Ezequiel Garcia wrote:

> I'm working on adding JimTcl [1] to Buildroot. The first issue you
> found is that Jim Tcl uses autosetup [2]
> instead of autotools. So my first approach is creating a
> "generic-package" jimtcl.mk.

Gustavo already pointed you on IRC to
http://repo.or.cz/w/buildroot-gz.git/commitdiff/651525c5c4f66c0f8fbc3ac518632c514bee4866.
Any reason not to use it? This patch is also in our patchwork at
http://patchwork.ozlabs.org/patch/181627/.


> Knowing it's ugly, I'd like to ask what's the 'nice' way of doing it:
> 
> #############################################################
> #
> # Jim Tcl 0.73
> #
> #############################################################
> 
> JIMTCL_VERSION = 0.73
> JIMTCL_SITE = git://repo.or.cz/jimtcl.git
> JIMTCL_SITE_METHOD = git
> 
> JIMTCL_INSTALL_STAGING = YES
> 
> define JIMTCL_CONFIGURE_CMDS
> 	(cd $(@D); PATH=$(PATH):/home/foo/buildroot/buildroot/output/host/usr/bin \
> 		./configure --host=$(GNU_TARGET_NAME) --prefix=$(STAGING_DIR))

prefix of STAGING_DIR is most likely wrong. It should be /usr in most
cases.

> endef
> 
> define JIMTCL_BUILD_CMDS
> 	PATH=$(PATH):/home/foo/buildroot/buildroot/output/host/usr/bin \
> 		$(MAKE) -C $(@D)
> endef
> 
> define JIMTCL_INSTALL_STAGING_CMDS
> 	PATH=$(PATH):/home/foo/buildroot/buildroot/output/host/usr/bin \
> 		$(MAKE) -C $(@D) install
> endef

	$(TARGET_MAKE_ENV) $(MAKE) ...

TARGET_MAKE_ENV already sets a PATH variable that has the toolchain
directory in it. See package/Makefile.in for the definition of
TARGET_MAKE_ENV.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-06-25 19:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-25 18:23 [Buildroot] Some issues found while trying to add JimTcl to buildroot Ezequiel Garcia
2013-06-25 19:20 ` Thomas Petazzoni [this message]
2013-06-25 19:29   ` Ezequiel Garcia
2013-06-25 19:37     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130625212043.3d224da3@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox