Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/libsvg: new package
Date: Sun, 30 Jun 2013 22:25:04 +0200	[thread overview]
Message-ID: <20130630222504.7e6131b8@skate> (raw)
In-Reply-To: <1372593363-10994-1-git-send-email-c.schoenert@gmail.com>

Dear Carsten Schoenert,

On Sun, 30 Jun 2013 13:56:03 +0200, Carsten Schoenert wrote:

> +config BR2_PACKAGE_LIBSVG
> +	bool "libsvg"
> +	select BR2_PACKAGE_LIBXML2 if !BR2_PACKAGE_LIBSVG_EXPAT

I don't think we want the BR2_PACKAGE_LIBSVG_EXPAT option. Just make
this:

	select BR2_PACKAGE_LIBXML2 if !BR2_PACKAGE_EXPAT

> +	help
> +	  Libsvg provides a parser for SVG content in files or buffers.
> +	  Libsvg does not do any rendering, but instead provides a
> +	  function-based interface that can be used by various rendering
> +	  engines.
> +
> +	  http://cairographics.org/snapshots/
> +
> +if BR2_PACKAGE_LIBSVG
> +
> +config BR2_PACKAGE_LIBSVG_EXPAT
> +    bool "use expat XML parser library"
> +	select BR2_PACKAGE_EXPAT
> +	default y
> +	help
> +	  Libsvg needs a XML parsing library!
> +	  Select expat if you want to use the Expat XML Parser library,
> +	  otherwhise the libxml2 library will be used.

Remove this option.


> +LIBSVG_VERSION         = 0.1.4
> +LIBSVG_SITE            = http://cairographics.org/snapshots/
> +LIBSVG_DEPENDENCIES    = host-pkgconf libpng libjpeg
> +LIBSVG_INSTALL_STAGING = YES
> +LIBSVG_LICENSE         = LGPLv2+
> +LIBSVG_LICENSE_FILES   = COPYING
> +
> +# libsvg needs at last a XML parser
> +ifeq ($(BR2_PACKAGE_LIBSVG_EXPAT),y)

ifeq ($(BR2_PACKAGE_EXPAT),y)

> +LIBSVG_CONF_OPT += --with-expat
> +LIBSVG_DEPENDENCIES += expat
> +else ifeq ($(BR2_PACKAGE_LIBXML2),y)
> +LIBSVG_CONF_OPT += --with-libxml2
> +LIBSVG_DEPENDENCIES += libxml2
> +endif
> +
> +$(eval $(autotools-package))

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-06-30 20:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-30 11:56 [Buildroot] [PATCH v2] package/libsvg: new package Carsten Schoenert
2013-06-30 20:25 ` Thomas Petazzoni [this message]
2013-07-01  7:56 ` Peter Korsgaard
2013-07-01 17:04   ` Carsten Schoenert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130630222504.7e6131b8@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox