From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Wed, 10 Jul 2013 09:16:28 +0200 Subject: [Buildroot] [PATCH] system: add option to pass extra args to post-build and post-image scripts In-Reply-To: <20130709183505.GB3543@free.fr> References: <1373393196-19024-1-git-send-email-yann.morin.1998@free.fr> <20130709183505.GB3543@free.fr> Message-ID: <20130710091628.1d01d59c@skate> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear Yann E. MORIN, On Tue, 9 Jul 2013 20:35:05 +0200, Yann E. MORIN wrote: > This was refused (and rightfully) as that would greatly impact users > depending on the current behaviour, and some alternate solution were > proposed: > - have a single script that would behave differently on how it sould > be called, and have different symlinks pointing to that script; > - have a script for each configuration, that 'sources' a functions > file and call the required functions > > After playing a bit with both solutions, it turned out to be not > entirely manageable, especially when the inrastructure put in place by > the functions changes, since all scripts must be changed accordingly. I am not quite sure to understand why the symlink solution doesn't work in your case. Could you elaborate on that? Regarding the patch itself, I'd say why not. I'm just wondering if it wouldn't be better to have separate arguments for both scripts. Not sure. Thanks! Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com