Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 2/2] qt: add powervr and opengl
Date: Thu, 11 Jul 2013 10:47:44 +0200	[thread overview]
Message-ID: <20130711104744.7fa84966@skate> (raw)
In-Reply-To: <51DDAF1A.5040602@carallon.com>

Dear Will Wagner,

On Wed, 10 Jul 2013 19:59:38 +0100, Will Wagner wrote:

> > +config BR2_PACKAGE_QT_GFX_POWERVR
> > +	depends on BR2_PACKAGE_QT_OPENGL_ES
> > +	depends on BR2_PACKAGE_TI_GFX
> > +	bool "powervr"
> > +
> 
> I don't like that this depends on the TI_GFX package. When I added 
> powervr support to Qt I added a powervr virtual package the same as 
> opengl_es or opengl_egl. This allows Qt to not contain anything specific 
> to the hardware graphics package.

I don't quite understand this. The Qt code that gets enabled with this
option *is* specific to this very driver, so it makes a lot of sense to
have this dependency.

If at some point in the future, we have a different package that is
API-compatible with the ti-gfx package and allows the same Qt PowerVR
code to be enabled, then it will be good time to have a virtual
package. Virtual packages have not impact on the Config.in options
stored in .config, so moving things to a virtual package does not break
the .config API, so we can safely do that in the future, when needed.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  parent reply	other threads:[~2013-07-11  8:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-10 18:10 [Buildroot] [PATCH v4 2/2] qt: add powervr and opengl Spenser Gilliland
2013-07-10 18:59 ` Will Wagner
2013-07-10 19:41   ` Spenser Gilliland
2013-07-11  8:47   ` Thomas Petazzoni [this message]
2013-07-11  9:16     ` Will Wagner
2013-07-11  9:45       ` Thomas Petazzoni
2013-07-11 16:51         ` Spenser Gilliland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130711104744.7fa84966@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox