Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC 2/3] sunxi-mali: new package
Date: Thu, 18 Jul 2013 10:16:01 +0200	[thread overview]
Message-ID: <20130718101601.57ccc624@skate> (raw)
In-Reply-To: <CAEBucnAAdKuub3sHu4emRcCj8Kw=O1nE4DDEEFZd2fK4XRCYjg@mail.gmail.com>

Dear Spenser Gilliland,

On Thu, 18 Jul 2013 02:21:44 -0500, Spenser Gilliland wrote:

> > Ok. As discussed on IRC, one option would be to extend the download
> > infrastructure to be able to pass the --recursive option to Git. Not
> > sure it's worth the effort for one package though. Maybe what you did
> > with sunxi-mali + sunxi-mali-prop is the simplest option for now. As I
> > noted, it should however be documented.
> 
> Because git-archive does not easily support creating tarballs of git
> submodule based projects, I've decided to keep the current structure.

Right, sounds good to me.

> Just as further discussion, I went down the path of transforming the
> CONFIGURE step into a post extract hook. However, I'm concerned that
> this may cause a race condition if the post-extract-hook occurs before
> sunxi-mali-prop is extracted. Perhaps, this needs to be a post
> configure hook so that the dependency is satisfied.

You are absolutely correct. By the time sunxi-mali is extracted, there
is no guarantee at all that sunxi-mali-prop will be extracted, so my
suggestion of moving the copying of sunxi-mali-prop stuff into
sunxi-mali sources at the extract step clearly doesn't work. Doing it
at the configure stage as you did is the only solution, so you were
right.

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-07-18  8:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-14  5:10 [Buildroot] [RFC 0/3] ARM Mali Graphics Drivers Spenser Gilliland
2013-07-14  5:10 ` [Buildroot] [RFC 1/3] a10disp: new package Spenser Gilliland
2013-07-16  8:21   ` Thomas Petazzoni
2013-07-16 15:46     ` Spenser Gilliland
2013-07-14  5:10 ` [Buildroot] [RFC 2/3] sunxi-mali: " Spenser Gilliland
2013-07-16  8:55   ` Thomas Petazzoni
2013-07-16 16:46     ` Spenser Gilliland
2013-07-16 19:08       ` Thomas Petazzoni
2013-07-18  7:21         ` Spenser Gilliland
2013-07-18  8:16           ` Thomas Petazzoni [this message]
2013-07-16 20:14   ` Yann E. MORIN
2013-07-18  6:12     ` Spenser Gilliland
2013-07-18  7:16       ` Thomas Petazzoni
2013-07-18 16:29       ` Yann E. MORIN
2013-07-14  5:10 ` [Buildroot] [RFC 3/3] opengl: add sunxi-mali as possible egl/gles provider Spenser Gilliland
2013-07-16  8:55   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130718101601.57ccc624@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox