Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] <pkg>-rsync: support user custom cmds
Date: Sun, 28 Jul 2013 15:03:34 +0200	[thread overview]
Message-ID: <20130728150334.6a8a862c@skate> (raw)
In-Reply-To: <1375007963-15935-1-git-send-email-tjlee@ambarella.com>

Dear Tzu-Jung Lee,

On Sun, 28 Jul 2013 18:39:23 +0800, Tzu-Jung Lee wrote:
> This patch allows users to override the options or entire command
> line of rsync.  The default options filters out object or libraries
> during rsync.  For local packages which come with pre-built binaries,
> the copy in build/ directory will not have complete files as src/

Hum, I am not sure this is the right way to fix this. When it was
introduced, I thought the --cvs-exclude option was only ignoring things
like CVS/ directories, .svn/ directories or .git/ directories. But now
that I read the rsync man page, I see that it excludes a huge number of
other file name patterns, which I think isn't desirable.

So rather than providing a way for the user to override the rsync
command, I'd prefer the rsync command to behave appropriately. I
believe it should simply copy /everything/, including version control
directories. Yes that's longer, but there's no reasonable generic way
to determine which files should be copied and which files should not.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-07-28 13:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-27 16:56 [Buildroot] [PATCH] <pkg>-rsync: support user custom cmds Tzu-Jung Lee
2013-07-28  8:22 ` Thomas De Schampheleire
2013-07-28 10:39   ` [Buildroot] [PATCH v2] " Tzu-Jung Lee
2013-07-28 13:03     ` Thomas Petazzoni [this message]
2013-07-28 13:15       ` Thomas De Schampheleire
2013-07-28 13:57         ` Thomas De Schampheleire
2013-07-28 14:17           ` Tzu-Jung Lee
2013-07-29  6:48             ` [Buildroot] [PATCH v3] " Tzu-Jung Lee
2013-08-07 19:59             ` [Buildroot] [PATCH v2] " Thomas De Schampheleire
2013-08-20 15:08               ` Thomas De Schampheleire
2013-08-20 18:14                 ` Tzu-Jung Lee
2013-08-21  6:09                   ` Arnout Vandecappelle
2013-08-21  7:20                     ` Tzu-Jung Lee
2013-08-21 16:41                       ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130728150334.6a8a862c@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox