From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1 of 2 v2] infra: introduce suitable-extractor helper function
Date: Fri, 2 Aug 2013 10:28:51 +0200 [thread overview]
Message-ID: <20130802102851.388356b2@skate> (raw)
In-Reply-To: <b277803240198c7900d9.1375390547@BEANTN0L019720>
Dear Thomas De Schampheleire,
On Thu, 01 Aug 2013 22:55:47 +0200, Thomas De Schampheleire wrote:
> diff --git a/package/pkg-utils.mk b/package/pkg-utils.mk
> --- a/package/pkg-utils.mk
> +++ b/package/pkg-utils.mk
> @@ -62,6 +62,8 @@ INFLATE.tbz2 = $(BZCAT)
> INFLATE.tgz = $(ZCAT)
> INFLATE.xz = $(XZCAT)
> INFLATE.tar = cat
> +# suitable-extractor(filename): returns extractor based on suffix
> +suitable-extractor = $(firstword $(INFLATE$(suffix $(1))))
Do you know why we need this $(firstword ...) call here? In all places
in was using directly $(INFLATE$(...)), except in the package
infrastructure where it was doing this firstword additional call.
It was added by Peter in 2c6390a5d0c01420879e9f23bc89afb19976da4a.
Ideas?
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-08-02 8:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 20:55 [Buildroot] [PATCH 0 of 2 v2] Introduce suitable-extractor and add host-xzcat dependency Thomas De Schampheleire
2013-08-01 20:55 ` [Buildroot] [PATCH 1 of 2 v2] infra: introduce suitable-extractor helper function Thomas De Schampheleire
2013-08-02 8:28 ` Thomas Petazzoni [this message]
2013-08-02 8:50 ` Thomas De Schampheleire
2013-08-02 8:56 ` Thomas Petazzoni
2013-08-02 9:02 ` Thomas De Schampheleire
2013-08-01 20:55 ` [Buildroot] [PATCH 2 of 2 v2] xzcat: treat as host prerequisite and build if needed Thomas De Schampheleire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130802102851.388356b2@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox