From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] ltrace: Fix a May be unitialized variable
Date: Fri, 9 Aug 2013 13:20:39 +0300 [thread overview]
Message-ID: <20130809102039.GB3703@tarshish> (raw)
In-Reply-To: <1376041019-26688-3-git-send-email-jezz@sysmic.org>
Hi J?r?me,
On Fri, Aug 09, 2013 at 11:36:58AM +0200, J?r?me Pouiller wrote:
> Compilation may failed if rlm is not initialized and ltrace
> is compiled with -Werror.
The right fix, in my opinion, is to disable -Werror. Otherwise, we'll have to
add more and more fixes like this one for each bump of the toolchain.
baruch
> Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
> ---
> .../ltrace-fix-may-be-uninitialized-variable.patch | 11 +++++++++++
> 1 file changed, 11 insertions(+)
> create mode 100644 package/ltrace/ltrace-fix-may-be-uninitialized-variable.patch
>
> diff --git a/package/ltrace/ltrace-fix-may-be-uninitialized-variable.patch b/package/ltrace/ltrace-fix-may-be-uninitialized-variable.patch
> new file mode 100644
> index 0000000..23ffc94
> --- /dev/null
> +++ b/package/ltrace/ltrace-fix-may-be-uninitialized-variable.patch
> @@ -0,0 +1,11 @@
> +--- a/sysdeps/linux-gnu/proc.c 2012-12-04 13:36:23.000000000 +0100
> ++++ b/sysdeps/linux-gnu/proc.c 2013-08-09 10:14:33.576464435 +0200
> +@@ -483,7 +483,7 @@
> + arch_addr_t addr = (arch_addr_t)(uintptr_t)dbg->r_map;
> +
> + while (addr != 0) {
> +- struct lt_link_map_64 rlm;
> ++ struct lt_link_map_64 rlm = { };
> + if (lm_fetcher(proc)(proc, addr, &rlm) < 0) {
> + debug(2, "Unable to read link map");
> + return;
> --
> 1.7.9.5
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2013-08-09 10:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 9:36 [Buildroot] [PATCH 0/3] Fix ltrace autobuilder failures Jérôme Pouiller
2013-08-09 9:36 ` [Buildroot] [PATCH 1/3] ltrace: Explicit enable/disable of libunwind Jérôme Pouiller
2013-08-09 10:23 ` Baruch Siach
2013-08-09 10:24 ` Thomas Petazzoni
2013-08-09 9:36 ` [Buildroot] [PATCH 2/3] ltrace: Fix a May be unitialized variable Jérôme Pouiller
2013-08-09 10:20 ` Baruch Siach [this message]
2013-08-09 10:28 ` Thomas Petazzoni
2013-08-09 9:36 ` [Buildroot] [PATCH 3/3] ltrace: Fix "strndup not declared" build failure on powerpc/uclibc Jérôme Pouiller
2013-08-09 10:24 ` Baruch Siach
2013-08-09 10:29 ` Thomas Petazzoni
2013-08-09 11:05 ` Thomas De Schampheleire
2013-08-09 20:30 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130809102039.GB3703@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox