Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] ola: new package
Date: Mon, 12 Aug 2013 20:01:08 +0200	[thread overview]
Message-ID: <20130812200108.3e03fc40@skate> (raw)
In-Reply-To: <CALy4uEXhixrLNKzrRVsdYqCeNer6XPB_kXKwJepH8Pnh9+M+mA@mail.gmail.com>

Dear David Skok,

Please always keep the Buildroot mailing list Cc'ed when continuing
discussions that started on the list.

On Mon, 12 Aug 2013 08:26:57 -0400, David Skok wrote:

> I've made the changes you point out.  My apologies but I don't know
> what you mean by "patch is not wrapped" and is (is not?) proper
> format.

What I meant is that your latest patch was perfect.

Often, when people send patches with their normal e-mail client, most
e-mail clients tend to "wrap" lines at 80 characters or so: instead of
having very very long lines, you have lines nicely wrapped at a
reasonable length.

However, while this is very useful when exchanging text, it falls apart
when exchanging patches, because the wrapping feature of the e-mail
clients breaks the patches and they can no longer be applied.

By using 'git send-email' (as you did), you make sure that your e-mail
client will not interfere with how the patch is sent, and specifically
that it doesn't get wrapped.

> I use git command line outlined in buildroot manual to send
> it.  I am new to contributing to open source and am doing my best to
> learn compliance for contribution.  Thank you for your patience so
> far.
> 
> Regarding the compile problem.  I have worked with the maintainer
> previously while I was testing package to correct compile issues.  I
> also test result with success.  The external compiler I used at the
> time was linaro 2013.01 which was option in buildroot for ARM A8 then.
>  I will verify error with configuration you report and find a solution
> asap.

I must say I haven't tested with a Linaro toolchain, which is glibc
based, and I only tested with an uClibc based toolchain. However,
seeing the message, I don't really suspect a glibc vs. uClibc
difference.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  parent reply	other threads:[~2013-08-12 18:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-07 13:10 [Buildroot] [PATCH 1/1] ola: new package Dave Skok
2013-08-10 17:13 ` Thomas Petazzoni
     [not found]   ` <CALy4uEXhixrLNKzrRVsdYqCeNer6XPB_kXKwJepH8Pnh9+M+mA@mail.gmail.com>
2013-08-12 18:01     ` Thomas Petazzoni [this message]
2013-08-12 18:36       ` David Skok
  -- strict thread matches above, loose matches on Subject: below --
2013-08-12 18:05 Dave Skok
2013-08-13 22:32 ` Thomas Petazzoni
2013-08-14  0:51   ` Blanco
2013-08-15 17:04 Dave Skok
2013-08-22  8:25 ` Thomas De Schampheleire
2013-08-26 12:36   ` David Skok
2013-08-26 14:02 Dave Skok
2013-08-27  8:04 ` Thomas De Schampheleire
2013-08-27 16:57 ` Arnout Vandecappelle
2013-08-28 11:51   ` David Skok
2013-08-28 11:50 Dave Skok
2013-09-12 21:03 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130812200108.3e03fc40@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox