From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] imagemagick: fix magick++-config fixup error
Date: Tue, 13 Aug 2013 11:49:25 +0200 [thread overview]
Message-ID: <20130813114925.07bb66a5@skate> (raw)
In-Reply-To: <20130813082128.6C4929B2E2@busybox.osuosl.org>
Dear Thomas Petazzoni,
On Tue, 13 Aug 2013 10:16:11 +0200, Thomas Petazzoni wrote:
> commit: http://git.buildroot.net/buildroot/commit/?id=b339bb5641c59ad2e19aeb95c1387584c7c2aeab
> branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>
> Magic++ bindings are built only with C++ and WCHAR toolchains.
> Add a WCHAR toolchain check for the magick++ config fixup.
> Looking into the future the fixup shouldn't bail on a missing file so we
> can avoid awkward kludges for packages that have many options and config
> files.
> Fixes:
> http://autobuild.buildroot.net/results/33a/33ac4b17866a64379b7bab3c0549f6e075c98dde/
Thanks, committed.
However, I think I disagree on the idea that the fixup shouldn't bail
on a missing file. Bailing out is the best way to notice that something
is wrong, otherwise problems remain unnoticed.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
prev parent reply other threads:[~2013-08-13 9:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 8:16 [Buildroot] [git commit] imagemagick: fix magick++-config fixup error Thomas Petazzoni
2013-08-13 9:49 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130813114925.07bb66a5@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox