Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] neon: replace 'choice' for XML library with two options
Date: Tue, 27 Aug 2013 09:24:49 +0200	[thread overview]
Message-ID: <20130827092449.45fe7340@skate> (raw)
In-Reply-To: <521C447D.4020207@mind.be>

Dear Arnout Vandecappelle,

On Tue, 27 Aug 2013 08:17:33 +0200, Arnout Vandecappelle wrote:

> >   config BR2_PACKAGE_NEON_EXPAT
> > -	bool "expat"
> > +	bool "XML support with expat"
> >   	select BR2_PACKAGE_EXPAT
> > +	depends on BR2_PACKAGE_NEON
> 
>   Can you use "if ... endif" instead of depends on?

See PATCH 2/3 in the series :)

> >   config BR2_PACKAGE_RPM
> >   	bool "rpm"
> >   	depends on BR2_TOOLCHAIN_HAS_THREADS # beecrypt
> >   	select BR2_PACKAGE_BEECRYPT
> >   	select BR2_PACKAGE_POPT
> >   	select BR2_PACKAGE_OPENSSL
> > -	depends on BR2_PACKAGE_NEON
> > -	depends on !BR2_PACKAGE_NEON_NOXML
> > +	select BR2_PACKAGE_NEON
> > +	select BR2_PACKAGE_NEON_EXPAT if !BR2_PACKAGE_NEON_LIBXML2
> 
>   Maybe it's cleaner to add a hidden symbol to neon:
> 
> config BR2_PACKAGE_NEON_XML
> 	bool
> 	select BR2_PACKAGE_NEON_EXPAT if !BR2_PACKAGE_NEON_LIBXML2
> 
>   Then in rpm, you only need to select BR2_PACKAGE_NEON_XML

Right, seems like a good idea, I'll try that.

Thanks,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-08-27  7:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-24 11:07 [Buildroot] [PATCH 0/3] Subversion package and related patches Thomas Petazzoni
2013-08-24 11:07 ` [Buildroot] [PATCH 1/3] neon: replace 'choice' for XML library with two options Thomas Petazzoni
2013-08-27  6:17   ` Arnout Vandecappelle
2013-08-27  7:24     ` Thomas Petazzoni [this message]
2013-08-24 11:07 ` [Buildroot] [PATCH 2/3] neon: factorize 'depends on BR2_PACKAGE_NEON' Thomas Petazzoni
2013-08-24 11:07 ` [Buildroot] [PATCH 3/3] subversion: new package Thomas Petazzoni
2013-08-26  8:12 ` [Buildroot] [PATCH 0/3] Subversion package and related patches Rico Bachmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130827092449.45fe7340@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox