From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 5/5] kmod: does not support static builds
Date: Tue, 27 Aug 2013 18:48:28 +0200 [thread overview]
Message-ID: <20130827184828.7a7685b1@skate> (raw)
In-Reply-To: <52151C54.9010606@mind.be>
Dear Arnout Vandecappelle,
(Resending with Buildroot list in Cc)
On Wed, 21 Aug 2013 22:00:20 +0200, Arnout Vandecappelle wrote:
> On 20/08/13 13:03, Thomas Petazzoni wrote:
> > Since kmod 14, the support for building a static library has been
> > removed completely from kmod. Therefore, we mark kmod as
> > !BR2_PREFER_STATIC_LIB, as well as all its reverse dependencies, which
> > includes the option to use the "udev" /dev management method.
> >
> > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>
> I don't think that patches that fix PREFER_STATIC builds are important
> enough to still include in 2013.08.
I agree.
> > diff --git a/package/kmod/Config.in b/package/kmod/Config.in
> > index 4965237..bd44316 100644
> > --- a/package/kmod/Config.in
> > +++ b/package/kmod/Config.in
> > @@ -1,5 +1,6 @@
> > config BR2_PACKAGE_KMOD
> > bool "kmod"
> > + depends on !BR2_PREFER_STATIC_LIB
> > help
> > handle kernel modules
>
> Shouldn't you also remove the
>
> KMOD_CONF_OPT = --disable-static --enable-shared
>
> ?
No because the default is --enable-static --enable-shared, and the
configure script of kmod bails out with an error when --enable-static
is passed.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-08-27 16:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 11:02 [Buildroot] [PATCH 0/5] Set of fixes, for 2013.08 Thomas Petazzoni
2013-08-20 11:03 ` [Buildroot] [PATCH 1/5] attr: add patch to fix static installation Thomas Petazzoni
2013-08-23 13:28 ` Gustavo Zacarias
2013-08-20 11:03 ` [Buildroot] [PATCH 2/5] acl: " Thomas Petazzoni
2013-08-23 13:28 ` Gustavo Zacarias
2013-08-20 11:03 ` [Buildroot] [PATCH 3/5] Makefile: test before search for kernel modules Thomas Petazzoni
2013-08-21 7:08 ` Luca Ceresoli
2013-08-20 11:03 ` [Buildroot] [PATCH 4/5] Makefile: do not try to strip inexisting file when stripping libpthread Thomas Petazzoni
2013-08-21 19:33 ` Arnout Vandecappelle
2013-09-02 21:13 ` Peter Korsgaard
2013-08-20 11:03 ` [Buildroot] [PATCH 5/5] kmod: does not support static builds Thomas Petazzoni
[not found] ` <52151C54.9010606@mind.be>
2013-08-27 16:48 ` Thomas Petazzoni [this message]
2013-09-02 21:32 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130827184828.7a7685b1@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox