From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 10/12] toolchain: refactor Stack Smashing Protection support
Date: Thu, 29 Aug 2013 10:34:19 +0200 [thread overview]
Message-ID: <20130829103419.1ed476b9@skate> (raw)
In-Reply-To: <521EE62A.9000805@mind.be>
Dear Arnout Vandecappelle,
On Thu, 29 Aug 2013 08:11:54 +0200, Arnout Vandecappelle wrote:
> On 08/28/13 08:35, Thomas Petazzoni wrote:
> [snip]
> > diff --git a/package/psmisc/psmisc.mk b/package/psmisc/psmisc.mk
> > index 1340ee6..61faeab 100644
> > --- a/package/psmisc/psmisc.mk
> > +++ b/package/psmisc/psmisc.mk
> > @@ -10,7 +10,7 @@ PSMISC_LICENSE = GPLv2
> > PSMISC_LICENSE_FILES = COPYING
> > PSMISC_DEPENDENCIES = ncurses $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext)
> >
> > -ifneq ($(BR2_TOOLCHAIN_BUILDROOT_USE_SSP),y)
> > +ifneq ($(BR2_ENABLE_SSP),y)
> > # Don't force -fstack-protector
> > PSMISC_CONF_OPT = --disable-harden-flags
> > endif
>
> If psmisc normally uses -fstack-protector, then I wouldn't disable that
> just because the user hasn't chosen to enable the option globally.
>
> In other words, I'd put
>
> ifneq ($(BR2_TOOLCHAIN_HAS_SSP),y)
Sure, why not.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-08-29 8:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 6:35 [Buildroot] [PATCH 00/12] Toolchain updates Thomas Petazzoni
2013-08-28 6:35 ` [Buildroot] [PATCH 01/12] package/Makefile.in: fix incorrect comment Thomas Petazzoni
2013-08-28 6:35 ` [Buildroot] [PATCH 02/12] eglibc: libstdc++ is not part of the C library Thomas Petazzoni
2013-08-28 6:35 ` [Buildroot] [PATCH 03/12] toolchain-internal: skip gcc-intermediate when possible Thomas Petazzoni
2013-08-28 6:35 ` [Buildroot] [PATCH 04/12] gcc: fix Fortran support Thomas Petazzoni
2013-08-28 6:35 ` [Buildroot] [PATCH 05/12] gcc: fix Objective-C support Thomas Petazzoni
2013-08-28 6:35 ` [Buildroot] [PATCH 06/12] gcc: move C++ support option next to Fortran/Objective-C Thomas Petazzoni
2013-08-28 6:35 ` [Buildroot] [PATCH 07/12] toolchain: add support for glibc Thomas Petazzoni
2013-08-28 6:35 ` [Buildroot] [PATCH 08/12] gcc/gcc-final: use the common HOST_GCC_CONFIGURE_SYMLINK macro Thomas Petazzoni
2013-08-28 6:35 ` [Buildroot] [PATCH 09/12] gcc: force symlink creation Thomas Petazzoni
2013-08-28 6:35 ` [Buildroot] [PATCH 10/12] toolchain: refactor Stack Smashing Protection support Thomas Petazzoni
2013-08-29 6:11 ` Arnout Vandecappelle
2013-08-29 8:34 ` Thomas Petazzoni [this message]
2013-08-28 6:35 ` [Buildroot] [PATCH 11/12] toolchain: move elf2flt option inclusion to toolchain-buildroot/Config.in Thomas Petazzoni
2013-08-28 6:35 ` [Buildroot] [PATCH 12/12] toolchain: improve mudflap support Thomas Petazzoni
2013-08-29 6:18 ` Arnout Vandecappelle
2013-08-29 7:56 ` Thomas Petazzoni
2013-08-29 11:24 ` Gustavo Zacarias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130829103419.1ed476b9@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox