Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] knock: new package
Date: Sat, 31 Aug 2013 13:50:01 +0200	[thread overview]
Message-ID: <20130831135001.3bf35efd@skate> (raw)
In-Reply-To: <1377899236-1659-1-git-send-email-rommel@layer-7.net>

Dear Michael Rommel,

Thanks for your contribution! I won't repeat the comments made by
Thomas De Schampheleire since they are all obviously valid. Let me add
one other nitpick comment below.

On Fri, 30 Aug 2013 23:47:16 +0200, Michael Rommel wrote:

> +KNOCK_VERSION=7666f2e86e18d482eaad5fe1fea46d87d80b0555
> +KNOCK_SITE=https://github.com/jvinet/knock/tarball/master

There should be spaces around the equal sign, like you did in the lines
below.

> +KNOCK_LICENSE = GPLv2

Is it really GPLv2 or GPLv2+ ? Can you check the copyright headers in
the source files?

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

      parent reply	other threads:[~2013-08-31 11:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-30 21:47 [Buildroot] [PATCH 1/1] knock: new package Michael Rommel
2013-08-31  8:56 ` Thomas De Schampheleire
2013-08-31 11:50 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130831135001.3bf35efd@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox