Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 03/10] sysvinit: add patch for libcrypt
Date: Sun, 8 Sep 2013 18:31:07 +0200	[thread overview]
Message-ID: <20130908183107.57a40dd8@skate> (raw)
In-Reply-To: <1378429464-12546-4-git-send-email-rjbarnet@rockwellcollins.com>

Dear Ryan Barnett,

On Thu, 5 Sep 2013 20:04:17 -0500, Ryan Barnett wrote:
> Adding a patch to sysvinit to correcctly add libcrypt as a build
> dependancy of sysvinit.

I believe this commit log should carry a bit more details as to what it
is fixing compared to what commit
f5e3178197ff17b9f4a4c2ecb6d32b72a38a1246 did.



> 
> Signed-off-by: Ryan Barnett <rjbarnet@rockwellcollins.com>
> ---
>  .../sysvinit-0001-libcrypt_check_fix.patch         |   13 +++++++++++++
>  package/sysvinit/sysvinit.mk                       |    2 +-
>  2 files changed, 14 insertions(+), 1 deletions(-)
>  create mode 100644 package/sysvinit/sysvinit-0001-libcrypt_check_fix.patch
> 
> diff --git a/package/sysvinit/sysvinit-0001-libcrypt_check_fix.patch b/package/sysvinit/sysvinit-0001-libcrypt_check_fix.patch
> new file mode 100644
> index 0000000..f6f54e5
> --- /dev/null
> +++ b/package/sysvinit/sysvinit-0001-libcrypt_check_fix.patch

All patches should have a description + Signed-off-by. See
http://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches.

> @@ -0,0 +1,13 @@
> +--- a/src/Makefile	2010-04-11 04:30:27.000000000 -0500
> ++++ b/src/Makefile	2012-09-05 12:44:45.000000000 -0500
> +@@ -78,8 +78,8 @@
> + endif
> + 
> + # Additional libs for GNU libc.
> +-ifneq ($(wildcard /usr/lib*/libcrypt.a),)
> +-  SULOGINLIBS	+= -lcrypt
> ++ifneq ($(LCRYPT),)
> ++  SULOGINLIBS	+= $(LCRYPT)
> + endif
> + 
> + all:		$(BIN) $(SBIN) $(USRBIN)
> diff --git a/package/sysvinit/sysvinit.mk b/package/sysvinit/sysvinit.mk
> index c6b75a0..7678bce 100644
> --- a/package/sysvinit/sysvinit.mk
> +++ b/package/sysvinit/sysvinit.mk
> @@ -31,7 +31,7 @@ SYSVINIT_POST_PATCH_HOOKS = SYSVINIT_DEBIAN_PATCHES
>  define SYSVINIT_BUILD_CMDS
>  	# Force sysvinit to link against libcrypt as it otherwise
>  	# use an incorrect test to see if it's available
> -	$(MAKE) $(TARGET_CONFIGURE_OPTS) SULOGINLIBS="-lcrypt" -C $(@D)/src
> +	$(MAKE) $(TARGET_CONFIGURE_OPTS) LCRYPT="-lcrypt" -C $(@D)/src
>  endef
>  
>  define SYSVINIT_INSTALL_TARGET_CMDS

Thanks,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-09-08 16:31 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-06  1:04 [Buildroot] [PATCH 00/10] Enable SELinux Support in Existing Packages Ryan Barnett
2013-09-06  1:04 ` [Buildroot] [PATCH 01/10] sysvinit: add support for SELinux Ryan Barnett
2013-09-08 16:27   ` Thomas Petazzoni
2013-09-06  1:04 ` [Buildroot] [PATCH 02/10] sysvinit: install new cmds and fix inittab Ryan Barnett
2013-09-08 16:29   ` Thomas Petazzoni
2013-09-06  1:04 ` [Buildroot] [PATCH 03/10] sysvinit: add patch for libcrypt Ryan Barnett
2013-09-08 16:31   ` Thomas Petazzoni [this message]
2013-09-06  1:04 ` [Buildroot] [PATCH 04/10] util-linux: add suport for SELinux Ryan Barnett
2013-09-08 16:32   ` Thomas Petazzoni
2013-09-06  1:04 ` [Buildroot] [PATCH 05/10] linux-pam: add support " Ryan Barnett
2013-09-08 16:33   ` Thomas Petazzoni
2013-09-06  1:04 ` [Buildroot] [PATCH 06/10] openssh: " Ryan Barnett
2013-09-08 16:35   ` Thomas Petazzoni
2013-09-06  1:04 ` [Buildroot] [PATCH 07/10] logrotate: " Ryan Barnett
2013-09-08 16:36   ` Thomas Petazzoni
2013-09-06  1:04 ` [Buildroot] [PATCH 08/10] coreutils: " Ryan Barnett
2013-09-08 16:36   ` Thomas Petazzoni
2013-09-06  1:04 ` [Buildroot] [PATCH 09/10] dbus: " Ryan Barnett
2013-09-08 16:40   ` Thomas Petazzoni
2013-09-06  1:04 ` [Buildroot] [PATCH 10/10] busybox: " Ryan Barnett
2013-09-08 16:46   ` Thomas Petazzoni
2013-09-08 16:26 ` [Buildroot] [PATCH 00/10] Enable SELinux Support in Existing Packages Thomas Petazzoni
2013-09-09 13:40   ` rjbarnet at rockwellcollins.com
2013-09-11 11:48     ` Thomas De Schampheleire
2013-09-11 14:58       ` Ryan Barnett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130908183107.57a40dd8@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox