From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 5/7] libpng12: new package
Date: Sun, 8 Sep 2013 19:04:57 +0200 [thread overview]
Message-ID: <20130908190457.6406d70d@skate> (raw)
In-Reply-To: <1378441521-10050-6-git-send-email-spenser@gillilanding.com>
Dear Spenser Gilliland,
On Thu, 5 Sep 2013 23:25:19 -0500, Spenser Gilliland wrote:
> +config BR2_PACKAGE_LIBPNG12
> + bool "libpng"
Maybe:
bool "libpng12"
> + select BR2_PACKAGE_ZLIB
> + help
> + Library for handling PNG (Portable Network Graphics)
> + images. This installs the 1.2.x series. Different versions of
> + libpng have different APIs.
> +
> + http://www.libpng.org/
> diff --git a/package/libpng12/libpng12.mk b/package/libpng12/libpng12.mk
> new file mode 100644
> index 0000000..39094f2
> --- /dev/null
> +++ b/package/libpng12/libpng12.mk
> @@ -0,0 +1,18 @@
> +################################################################################
> +#
> +# libpng12
> +#
> +################################################################################
> +
> +LIBPNG12_VERSION = 1.2.50
> +LIBPNG12_SERIES = 12
> +LIBPNG12_SOURCE = libpng-$(LIBPNG12_VERSION).tar.bz2
> +LIBPNG12_SITE = http://downloads.sourceforge.net/project/libpng/libpng$(LIBPNG12_SERIES)/$(LIBPNG12_VERSION)
> +LIBPNG12_LICENSE = libpng license
> +LIBPNG12_LICENSE_FILES = LICENSE
> +LIBPNG12_INSTALL_STAGING = YES
> +LIBPNG12_DEPENDENCIES = host-pkgconf zlib
> +LIBPNG12_CONFIG_SCRIPTS = libpng$(LIBPNG12_SERIES)-config libpng-config
This last one annoys me a bit: if both libpng and libpng12 install
libpng-config, it means that another package that runs libpng-config to
find out where libpng is and how to link against it will either be
linked against the modern libpng or the older libpng12 depending on
which one was installed.
Since libpng12 is only installed for compatibility reasons with some
packages, I would therefore suggest that we do not install
libpng-config in libpng12.mk (and ensure that nothing installed by
libpng12 can conflict with the real libpng installation).
Thoughts?
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-09-08 17:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 4:25 [Buildroot] [PATCH v2 0/7] glmark2 and Mesa updates Spenser Gilliland
2013-09-06 4:25 ` [Buildroot] [PATCH v2 1/7] libdrm: bump and add experimental ARM framebuffer support Spenser Gilliland
2013-09-08 16:51 ` Thomas Petazzoni
2013-09-20 8:41 ` Peter Korsgaard
2013-09-06 4:25 ` [Buildroot] [PATCH v2 2/7] sunxi-cedarx: bump to newer version, use armel2 binaries, add demo Spenser Gilliland
2013-09-08 16:59 ` Thomas Petazzoni
2013-09-12 4:41 ` Spenser Gilliland
2013-09-20 13:54 ` Peter Korsgaard
2013-09-06 4:25 ` [Buildroot] [PATCH v2 3/7] mesa3d: pull out from x11 Spenser Gilliland
2013-09-08 17:02 ` Thomas Petazzoni
2013-09-12 2:57 ` Spenser Gilliland
2013-09-12 7:23 ` Thomas Petazzoni
2013-09-06 4:25 ` [Buildroot] [PATCH v2 4/7] mesa3d: modularize and bump to version 9.1.6 Spenser Gilliland
2013-09-08 18:30 ` Thomas Petazzoni
2013-09-12 2:58 ` Spenser Gilliland
2013-09-06 4:25 ` [Buildroot] [PATCH v2 5/7] libpng12: new package Spenser Gilliland
2013-09-08 17:04 ` Thomas Petazzoni [this message]
2013-09-11 5:33 ` Arnout Vandecappelle
2013-09-12 3:20 ` Spenser Gilliland
2013-09-06 4:25 ` [Buildroot] [PATCH v2 6/7] glmark2: " Spenser Gilliland
2013-09-08 18:38 ` Thomas Petazzoni
2013-09-12 3:12 ` Spenser Gilliland
2013-09-11 5:47 ` Arnout Vandecappelle
2013-09-12 3:17 ` Spenser Gilliland
2013-09-30 20:39 ` Arnout Vandecappelle
2013-09-06 4:25 ` [Buildroot] [PATCH v2 7/7] mesa3d-demos: " Spenser Gilliland
2013-09-11 5:58 ` Arnout Vandecappelle
2013-09-12 3:21 ` Spenser Gilliland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130908190457.6406d70d@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox