From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yann E. MORIN Date: Thu, 12 Sep 2013 23:50:11 +0200 Subject: [Buildroot] [PATCH 0/3] Support for out-of-tree Buildroot customization In-Reply-To: References: <1378646129-4167-1-git-send-email-thomas.petazzoni@free-electrons.com> <20130911091700.0b24df41@skate> <20130911172709.GB3410@free.fr> Message-ID: <20130912215011.GB3362@free.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Thomas, All, On 2013-09-12 09:54 +0200, Thomas De Schampheleire spake thusly: > On Wed, Sep 11, 2013 at 7:27 PM, Yann E. MORIN wrote: > > Ryan, Thomas, All, > > > [..] > > > > Yes, as I said above, I would have expected companies (well, people at > > companies) be stressed by projects deadlines, and that they would work > > in BR2_EXTERNAL, and only try to upstream later, when it would be too > > late (for them!) to have proper reviews, since they would be internally > > committed to their changes in BR2_EXTERNAL, and we would not be able to > > take their changes. > > > > But if people use BR2_EXTERNAL as a fallback for anything that did not > > make it upstream (by lack of time, or of interest), or for purely > > internal stuff, then I don't see a reason for concern. All the better! :-) > > > > Not to ruin the atmosphere, but even though Ryan and his colleagues > may be using BR2_EXTERNAL 'the good way', ultimately helping the > buildroot project with their contributions, the danger of others not > doing that is still real. Yes, of course. Don't stop me from being optimistic for once, please! ;-) > Of course, _not_ contributing changes made > in a company project was also possible previously, without > BR2_EXTERNAL, so this is no reason to block the patchset. Quite the opposite: Thomas P. did convince me on IRC and with this patchset (which I have already started to ack). I still have to ack patch 2, and did not do so since I haven't yet reviewed and tested here first. So, no, I will not try to block this, but rather try to push it since it is a oft-wanted feature, and Thomas P has come up with a rather sane solution to do it the Buildroot way. This will eventually stop people from banging their heads on this for good. :-) Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'