Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC] Effective Patchwork Use and Patch Review
Date: Mon, 16 Sep 2013 17:48:21 +0200	[thread overview]
Message-ID: <20130916174821.41a0c368@skate> (raw)
In-Reply-To: <OFD4BE18C9.32F86585-ON86257BE8.004CBA65-86257BE8.005044AA@rockwellcollins.com>

Dear Ryan Barnett,

On Mon, 16 Sep 2013 09:36:44 -0500, Ryan Barnett wrote:

> > Agreed. When I wrote that patchwork improved the situation, I meant
> > that patchwork provided a good overview of outstanding patches, both
> > for reviewers as for maintainers.
> 
> OK that fine. I was just wondering if anyone had used patchworks
> to write some scripts to pull patches down and then mark-up and send 
> the review back out over email. My email client is a pain for this so
> I was just wondering if there was a way to not use it...

No, the only person using scripts for patchwork is really the
maintainer, so that when he applies patches, they are automatically
marked as "Applied" on the patchwork.

Also, since I (and a few other core developers) have some kind of admin
access to patchwork, we can mark patches as Superseded, Rejected, etc.
But we do this with the web interface.

> Under Section 10.2 of the manual, would it be useful to update this 
> say explicitly state that the review takes place over the mailing 
> list? Currently I think the section implies it that but doesn't
> say it explicitly. 

Sure, if anything is unclear in the manual, it's certainly worth making
it explicit.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

      reply	other threads:[~2013-09-16 15:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-13 16:41 [Buildroot] [RFC] Effective Patchwork Use and Patch Review Ryan Barnett
2013-09-14  5:47 ` Thomas Petazzoni
2013-09-14 19:08   ` Carsten Schoenert
2013-09-15 14:23   ` Thomas De Schampheleire
2013-09-16 14:36     ` Ryan Barnett
2013-09-16 15:48       ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130916174821.41a0c368@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox