From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] support for cubieboard2 added
Date: Mon, 16 Sep 2013 20:07:48 +0200 [thread overview]
Message-ID: <20130916200748.267bb602@skate> (raw)
In-Reply-To: <1379328727-2577-2-git-send-email-carlos@crqgestion.es>
Dear Carlos Quijano,
Generally looks good, except:
On Mon, 16 Sep 2013 12:52:05 +0200, Carlos Quijano wrote:
>
> Signed-off-by: Carlos Quijano <carlos@crqgestion.es>
> ---
> board/cubietech/cubieboard2/boot.cmd | 4 +
> .../cubieboard2/cubieboard2_kernel.config | 3158 ++++++++++++++++++++
The kernel configuration should be a minimal defconfig, generated with
'make ARCH=arm savedefconfig'. See the size of the kernel configuration
files for the other platforms.
Also, the file should be named just kernel.config, or linux.config, or
linux-<version>.config. Having the name of the board in the filename is
useless since it's already in a directory named after the board.
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-09-16 18:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 10:52 [Buildroot] Cubieboard2 support Carlos Quijano
2013-09-16 10:52 ` [Buildroot] [PATCH 1/3] support for cubieboard2 added Carlos Quijano
2013-09-16 18:07 ` Thomas Petazzoni [this message]
2013-09-16 19:12 ` Arnout Vandecappelle
2013-09-16 10:52 ` [Buildroot] [PATCH 2/3] updated author and readme Carlos Quijano
2013-09-16 18:08 ` Thomas Petazzoni
2013-09-16 10:52 ` [Buildroot] [PATCH 3/3] enable needed modules for cubieboard2 Carlos Quijano
2013-09-16 18:08 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130916200748.267bb602@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox