Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Cubieboard2 support
Date: Tue, 17 Sep 2013 20:14:20 +0200	[thread overview]
Message-ID: <20130917201420.68ca1366@skate> (raw)
In-Reply-To: <1379411163-8349-2-git-send-email-carlos@crqgestion.es>

Dear Carlos Quijano,

Thanks, but this patch lacks a proper commit log, and doesn't have a
Signed-off-by line. The title should also probably be something like
"board: add cubieboard2 support".

Other than that, it looks good to me. Can you fix these problems and
resend? Also, when you send updated versions, please update the version
number in the patch title, by doing:

 git format-patch --subject-prefix="PATCHv2" HEAD^

Thanks,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

      reply	other threads:[~2013-09-17 18:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-17  9:46 [Buildroot] Cubieboard2 support Carlos Quijano
2013-09-17  9:46 ` [Buildroot] [PATCH] " Carlos Quijano
2013-09-17 18:14   ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130917201420.68ca1366@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox