Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] Fix EGL support in qt5base
Date: Wed, 18 Sep 2013 18:27:09 +0200	[thread overview]
Message-ID: <20130918182709.7a845c19@skate> (raw)
In-Reply-To: <208f618f05b351b3ef2eddf624978189@sysmic.org>

Dear J?r?me Pouiller,

On Wed, 18 Sep 2013 13:13:57 +0200, J?r?me Pouiller wrote:

> > I'm sorry, but this really looks ugly.
> I agree :-)
> 
> In fact, I mainly  wrote this patch as a work around for  one of my 
> imx6
> compilations. I sent it only because Espen seemed to have same issue.

Ok, no problem :)

> > ifeq ($(BR2_PACKAGE_GPU_VIV_BIN_MX6Q),y)
> > QT5BASE_EGLFS_PLATFORM_HOOKS_SOURCES = \
> > 	$(@D)/mkspecs/devices/linux-imx6-g++/qeglfshooks_imx6.cpp
> > endif
> My idea  was QT5BASE_EGLFS_PLATFORM_HOOKS_SOURCES may not  be 
> sufficient
> to  support all  future cases  and we  may have  a more  generic way  
> to
> customize qmake.conf. But I am agree, this case is not yet arrived.

Of course, this might happen, but until that happens, let's not plan
something in advance without having any idea of what will exactly
happen :-)

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

      reply	other threads:[~2013-09-18 16:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-17  7:37 [Buildroot] Fix to Qt5base-build Espen Frimann Koren
2013-09-17  9:53 ` [Buildroot] [PATCH v1] Fix EGL support in qt5base Jérôme Pouiller
2013-09-17 11:35   ` Fatih Aşıcı
2013-09-17 18:33   ` Thomas Petazzoni
2013-09-18 11:13     ` Jérôme Pouiller
2013-09-18 16:27       ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130918182709.7a845c19@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox