From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] qt5base: fix build when egl headers need a definition
Date: Thu, 19 Sep 2013 06:12:33 +0200 [thread overview]
Message-ID: <20130919061233.35eb34e3@skate> (raw)
In-Reply-To: <523A1AE3.9090802@mind.be>
Dear Arnout Vandecappelle,
On Wed, 18 Sep 2013 23:28:03 +0200, Arnout Vandecappelle wrote:
> >> >+++ b/package/qt5/qt5base/qt5base-egl-cflags.patch
> > All patches should have a description, and a Signed-off-by line. See
> > http://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches.
>
> Also, please give your patch a number so that the order in which
> they're applied is predictable. At the moment this probably doesn't
> matter much, but it makes it easier later on to make sure a new patch
> will be applied after this one.
Yeah, I also wanted to ask that, but there are existing patches for
qt5base that doesn't comply with this, so I felt that it was maybe not
appropriate to ask a contributor to fix our (my ?) mess :-)
But indeed, Fatih, as a preparation patch, you could add number to the
existing patches, and then add your own.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-09-19 4:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 11:17 [Buildroot] [PATCH] qt5base: fix build when egl headers need a definition Fatih Aşıcı
2013-09-18 16:55 ` Thomas Petazzoni
2013-09-18 21:28 ` Arnout Vandecappelle
2013-09-19 4:12 ` Thomas Petazzoni [this message]
2013-09-19 17:36 ` Arnout Vandecappelle
-- strict thread matches above, loose matches on Subject: below --
2013-09-18 18:48 Fatih Aşıcı
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130919061233.35eb34e3@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox