From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] u-boot: allow to pass a custom configuration file
Date: Thu, 19 Sep 2013 17:43:36 +0200 [thread overview]
Message-ID: <20130919174336.537e265e@skate> (raw)
In-Reply-To: <1379589006-28682-1-git-send-email-eric.jarrige@armadeus.org>
Dear Eric Jarrige,
On Thu, 19 Sep 2013 13:10:06 +0200, Eric Jarrige wrote:
> choice
> + prompt "U-Boot configuration"
> + default BR2_TARGET_UBOOT_USE_DEFCONFIG
> +
> +config BR2_TARGET_UBOOT_USE_DEFCONFIG
> + bool "Using default configuration"
I don't think using the word 'defconfig' for U-Boot is appropriate,
since 'defconfig' really refers to a kconfig terminology and U-Boot,
sadly, doesn't use kconfig.
> define UBOOT_CONFIGURE_CMDS
> + $(if $(BR2_TARGET_UBOOT_USE_CUSTOM_CONFIG),
> + cp -pf $(call qstrip,$(BR2_TARGET_UBOOT_CUSTOM_CONFIG_FILE)) \
> + $(@D)/include/configs/$(UBOOT_BOARD_NAME).h)
> $(TARGET_CONFIGURE_OPTS) $(UBOOT_CONFIGURE_OPTS) \
> $(MAKE) -C $(@D) $(UBOOT_MAKE_OPTS) \
> $(UBOOT_BOARD_NAME)_config
I am a bit hesitant on the overall feature. The fact that a
include/configs/<something>.h file is really a configuration file is
pretty fuzzy in U-Boot, especially since now boards are supposed to
also be listed in the main boards.cfg file.
Therefore, I'm tempted to say that users who need to do that should
instead use patches against U-Boot (to add their own board, including
the include/configs/<something>.h file).
But on this one, I believe I can be convinced if there are good
arguments :)
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-09-19 15:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 11:10 [Buildroot] [PATCH 1/1] u-boot: allow to pass a custom configuration file Eric Jarrige
2013-09-19 15:43 ` Thomas Petazzoni [this message]
2013-09-19 20:07 ` Eric Jarrige
2013-09-20 5:08 ` Thomas Petazzoni
2013-09-20 9:51 ` Eric Jarrige
2013-09-20 10:01 ` Eric Jarrige
2013-09-20 11:03 ` [Buildroot] [PATCH v2] " Eric Jarrige
2013-09-20 11:11 ` [Buildroot] [PATCH v2 1/1] " Eric Jarrige
2014-04-30 6:11 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130919174336.537e265e@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox