Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 0/1] Allow svn tags and branches notation in $(PKG)_VERSION variable.
Date: Fri, 20 Sep 2013 06:28:49 +0200	[thread overview]
Message-ID: <20130920062849.0a7ba5ce@skate> (raw)
In-Reply-To: <2873382.jskDvbugG2@portaka>

Dear Ra?l S?nchez Siles,

On Thu, 19 Sep 2013 23:58:55 +0200, Ra?l S?nchez Siles wrote:

>   I still consider the key point is being able to encode the revision into the 
> $(PKG)_SOURCE variable.

I guess you meant "the key point is being able to encode the revision
into the $(PKG)_VERSION" variable. But I don't see why this is
important or useful, so could you explain why you believe it is
necessary?

For example, for Buildroot, doing:

LIBFOO2_VERSION = branches/featureA
LIBFOO2_SITE = http://svn.happyserver.net/theproject

is not recommended at all, because you don't know which version of
"featureA" you will be getting. One user may be fetching one revision,
and if another user builds the same Buildroot configuration a few days
later, it might be another revision with additional changes.

That's why you should instead use:

LIBFOO2_VERSION = <some revision number>
LIBFOO2_SITE = http://svn.happyserver.net/theproject/branches/featureA

What is the problem with doing this?

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

      parent reply	other threads:[~2013-09-20  4:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-18  5:11 [Buildroot] [PATCH 1/1] Allow svn tags and branches notation in $(PKG)_VERSION variable Raúl Sánchez Siles
2013-09-18 17:20 ` Thomas Petazzoni
2013-09-19 19:20   ` Peter Korsgaard
2013-09-19 21:54     ` [Buildroot] [PATCH v2 " Raúl Sánchez Siles
2013-09-19 21:58     ` [Buildroot] [PATCH v2 0/1] " Raúl Sánchez Siles
2013-09-19 22:04       ` Raúl Sánchez Siles
2013-09-20  4:28       ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130920062849.0a7ba5ce@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox