From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Add lesstif package
Date: Mon, 23 Sep 2013 14:12:22 +0200 [thread overview]
Message-ID: <20130923141222.2fb3c9a7@skate> (raw)
In-Reply-To: <52401C48.7090402@wanadoo.fr>
Dear Thierry Bultel,
On Mon, 23 Sep 2013 12:47:36 +0200, Thierry Bultel wrote:
> > Thierry> +# Remove the ac_find_motif.m4 that is copied on target
> > Thierry> +define LESSTIF_FIXACLOCAL
> > Thierry> + rm -rf $(TARGET_DIR)/$(HOME)
> > Thierry> +endef
> >
> > HOME?
>
> yes, current user $(HOME).
> This is weird indeed but lesstif actually creates
For those users who run Buildroot as root, this is going to remove
$(TARGET_DIR)/root from the root filesystem, which isn't nice. Also if
the user running Buildroot is foo and a 'foo' user has been created for
the target filesystem, it will remove its home directory.
Therefore, either the package should be patched not to install things
in such an odd location, or the removal should be made a bit more
specific. Remember to also test the case where Buildroot is built
out-of-tree using O=, since those files will then most likely not be
installed in $(TARGET_DIR)/$(HOME)/$(TOPDIR)/output.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2013-09-23 12:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 6:51 [Buildroot] [PATCH] Add lesstif package Thierry Bultel
2013-09-22 8:43 ` Peter Korsgaard
2013-09-22 13:41 ` Thomas Petazzoni
2013-09-23 7:36 ` Thierry Bultel
2013-09-23 7:49 ` Thomas Petazzoni
2013-09-23 10:47 ` Thierry Bultel
2013-09-23 10:50 ` Peter Korsgaard
2013-09-23 12:12 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130923141222.2fb3c9a7@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox