From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] gnupg: option to include RSA support.
Date: Sun, 29 Sep 2013 18:20:21 +0200 [thread overview]
Message-ID: <20130929182021.1417b3e0@skate> (raw)
In-Reply-To: <1380398533-12094-1-git-send-email-psanford@nearbuysystems.com>
Dear Peter Sanford,
Thanks! Some comments below.
On Sat, 28 Sep 2013 13:02:13 -0700, Peter Sanford wrote:
> +config BR2_PACKAGE_GNUPG_RSA
> + bool "RSA support"
> + help
> + Support for RSA public key algorithm
The indentation here is not good: it should be one tab before "bool"
and "help", and one tab+two spaces before the help text. See the
Buildroot manual and other examples throughout the Buildroot tree.
> +ifeq ($(BR2_PACKAGE_GNUPG_RSA),y)
> +GNUPG_CONF_OPT += --enable-rsa
> +endif
We generally like to have an "else" clause that explicitly disables the
option when not enabled, i.e:
else
GNUPG_CONF_OPT += --disable-rsa
endif
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2013-09-29 16:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-28 20:02 [Buildroot] [PATCH 1/1] gnupg: option to include RSA support Peter Sanford
2013-09-29 16:20 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130929182021.1417b3e0@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox