From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 04/11] libdrm: remove x11 dependency.
Date: Tue, 1 Oct 2013 21:02:14 +0200 [thread overview]
Message-ID: <20131001210214.1d5927ee@skate> (raw)
In-Reply-To: <1380237714-2470-5-git-send-email-spenser@gillilanding.com>
Dear Spenser Gilliland,
On Thu, 26 Sep 2013 18:21:47 -0500, Spenser Gilliland wrote:
>
> Signed-off-by: Spenser Gilliland <spenser@gillilanding.com>
> ---
> package/libdrm/Config.in | 3 +--
> package/libdrm/libdrm.mk | 3 +++
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/package/libdrm/Config.in b/package/libdrm/Config.in
> index 533e985..d67a6c2 100644
> --- a/package/libdrm/Config.in
> +++ b/package/libdrm/Config.in
> @@ -1,7 +1,6 @@
> config BR2_PACKAGE_LIBDRM
> bool "libdrm"
> - select BR2_PACKAGE_XLIB_LIBPTHREAD_STUBS
> - depends on BR2_PACKAGE_XORG7
> + select BR2_PACKAGE_LIBPTHREAD_STUBS
> depends on BR2_LARGEFILE
> help
> Direct Rendering Manager
> diff --git a/package/libdrm/libdrm.mk b/package/libdrm/libdrm.mk
> index da3a87c..f9438cd 100644
> --- a/package/libdrm/libdrm.mk
> +++ b/package/libdrm/libdrm.mk
> @@ -19,6 +19,9 @@ LIBDRM_CONF_OPT = \
> --disable-cairo-tests \
> --disable-manpages
>
> +LIBDRM_CONF_ENV = \
> + LIBS="-lrt -lpthread"
This hunk has nothing to do with the commit title. I am also not really
happy with those libraries being explicitly listed. I do remember the
problem that you had, and that we did not understand it completely, but
it doesn't seem right to do this.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-10-01 19:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 23:21 [Buildroot] [PATCH v3 00/11] glmark2 and Mesa updates Spenser Gilliland
2013-09-26 23:21 ` [Buildroot] [PATCH v3 01/11] udev: explicitly include pthreads Spenser Gilliland
2013-10-03 20:41 ` Peter Korsgaard
2013-10-08 14:55 ` Spenser Gilliland
2013-09-26 23:21 ` [Buildroot] [PATCH v3 02/11] sunxi-mali: add explicit pthread/dl/rt dependencies Spenser Gilliland
2013-09-26 23:21 ` [Buildroot] [PATCH v3 03/11] libpthread-stubs: move out of x11r7 Spenser Gilliland
2013-10-01 19:01 ` Thomas Petazzoni
2013-10-02 14:45 ` Spenser Gilliland
2014-01-08 19:03 ` Bernd Kuhls
2013-09-26 23:21 ` [Buildroot] [PATCH v3 04/11] libdrm: remove x11 dependency Spenser Gilliland
2013-10-01 19:02 ` Thomas Petazzoni [this message]
2013-10-02 14:44 ` Spenser Gilliland
2014-01-08 19:04 ` Bernd Kuhls
2013-09-26 23:21 ` [Buildroot] [PATCH v3 05/11] sunxi-cedarx: bump to newer version, use armel2 binaries, add demo Spenser Gilliland
2013-09-26 23:21 ` [Buildroot] [PATCH v3 06/11] mesa3d: pull out from x11 Spenser Gilliland
2013-09-26 23:21 ` [Buildroot] [PATCH v3 07/11] mesa3d: modularize and bump to version 9.1.6 Spenser Gilliland
2013-09-26 23:21 ` [Buildroot] [PATCH v3 08/11] libpng12: new package Spenser Gilliland
2013-09-26 23:21 ` [Buildroot] [PATCH v3 09/11] libpng: ensure libpng12 is installed before libpng Spenser Gilliland
2013-09-26 23:21 ` [Buildroot] [PATCH v3 10/11] glmark2: new package Spenser Gilliland
2013-09-26 23:21 ` [Buildroot] [PATCH v3 11/11] mesa3d-demos: " Spenser Gilliland
2014-01-05 16:17 ` [Buildroot] [PATCH v3 00/11] glmark2 and Mesa updates Bernd Kuhls
2014-01-06 0:07 ` Spenser Gilliland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131001210214.1d5927ee@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox